From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=33878 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OFOhI-0001r2-AY
	for qemu-devel@nongnu.org; Fri, 21 May 2010 05:39:20 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <aurelien@aurel32.net>) id 1OFOhF-00069a-BX
	for qemu-devel@nongnu.org; Fri, 21 May 2010 05:39:16 -0400
Received: from hall.aurel32.net ([88.191.82.174]:58453)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <aurelien@aurel32.net>) id 1OFOhF-00069H-2t
	for qemu-devel@nongnu.org; Fri, 21 May 2010 05:39:13 -0400
Date: Fri, 21 May 2010 11:38:59 +0200
From: Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH 12/22] tcg-i386: Tidy movi.
Message-ID: <20100521093859.GE1950@volta.aurel32.net>
References: <cover.1272479073.git.rth@twiddle.net>
	<59ddf19670e0a31cf421e350965fb5da4d86fcbf.1272479073.git.rth@twiddle.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Content-Disposition: inline
In-Reply-To: <59ddf19670e0a31cf421e350965fb5da4d86fcbf.1272479073.git.rth@twiddle.net>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>
Cc: qemu-devel@nongnu.org

On Wed, Apr 14, 2010 at 10:20:08AM -0700, Richard Henderson wrote:
> Define and use OPC_MOVL_Iv.
> 
> Signed-off-by: Richard Henderson <rth@twiddle.net>

Acked-by: Aurelien Jarno <aurelien@aurel32.net>

> ---
>  tcg/i386/tcg-target.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/tcg/i386/tcg-target.c b/tcg/i386/tcg-target.c
> index b4e8e74..06946e5 100644
> --- a/tcg/i386/tcg-target.c
> +++ b/tcg/i386/tcg-target.c
> @@ -178,6 +178,7 @@ static inline int tcg_target_const_match(tcg_target_long val,
>  #define OPC_MOVB_EvGv	(0x88)		/* stores, more or less */
>  #define OPC_MOVL_EvGv	(0x89)		/* stores, more or less */
>  #define OPC_MOVL_GvEv	(0x8b)		/* loads, more or less */
> +#define OPC_MOVL_Iv     (0xb8)
>  #define OPC_MOVZBL	(0xb6 | P_EXT)
>  #define OPC_MOVZWL	(0xb7 | P_EXT)
>  #define OPC_MOVSBL	(0xbe | P_EXT)
> @@ -305,7 +306,7 @@ static inline void tcg_out_movi(TCGContext *s, TCGType type,
>      if (arg == 0) {
>          tgen_arithr(s, ARITH_XOR, ret, ret);
>      } else {
> -        tcg_out8(s, 0xb8 + ret);
> +        tcg_out8(s, OPC_MOVL_Iv + ret);
>          tcg_out32(s, arg);
>      }
>  }
> -- 
> 1.6.6.1
> 
> 
> 
> 

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net