From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=34490 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OFOj2-0002jT-LE
	for qemu-devel@nongnu.org; Fri, 21 May 2010 05:41:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <aurelien@aurel32.net>) id 1OFOix-0006ZR-Fb
	for qemu-devel@nongnu.org; Fri, 21 May 2010 05:41:01 -0400
Received: from hall.aurel32.net ([88.191.82.174]:58504)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <aurelien@aurel32.net>) id 1OFOix-0006ZA-9x
	for qemu-devel@nongnu.org; Fri, 21 May 2010 05:40:59 -0400
Date: Fri, 21 May 2010 11:40:46 +0200
From: Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH 15/22] tcg-i386: Tidy ret.
Message-ID: <20100521094046.GG1950@volta.aurel32.net>
References: <cover.1272479073.git.rth@twiddle.net>
	<6755a46434c6501911b23df1a588afa1a2b4ea0e.1272479073.git.rth@twiddle.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Content-Disposition: inline
In-Reply-To: <6755a46434c6501911b23df1a588afa1a2b4ea0e.1272479073.git.rth@twiddle.net>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>
Cc: qemu-devel@nongnu.org

On Wed, Apr 14, 2010 at 11:04:14AM -0700, Richard Henderson wrote:
> Define and use OPC_RET.
> 
> Signed-off-by: Richard Henderson <rth@twiddle.net>

Acked-by: Aurelien Jarno <aurelien@aurel32.net>

> ---
>  tcg/i386/tcg-target.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/tcg/i386/tcg-target.c b/tcg/i386/tcg-target.c
> index e82788d..27e9e9e 100644
> --- a/tcg/i386/tcg-target.c
> +++ b/tcg/i386/tcg-target.c
> @@ -188,6 +188,7 @@ static inline int tcg_target_const_match(tcg_target_long val,
>  #define OPC_PUSH_r32	(0x50)
>  #define OPC_PUSH_Iv	(0x68)
>  #define OPC_PUSH_Ib	(0x6a)
> +#define OPC_RET		(0xc3)
>  #define OPC_SHIFT_1	(0xd1)
>  #define OPC_SHIFT_Ib	(0xc1)
>  #define OPC_SHIFT_cl	(0xd3)
> @@ -1426,7 +1427,7 @@ void tcg_target_qemu_prologue(TCGContext *s)
>      for(i = ARRAY_SIZE(tcg_target_callee_save_regs) - 1; i >= 0; i--) {
>          tcg_out_pop(s, tcg_target_callee_save_regs[i]);
>      }
> -    tcg_out8(s, 0xc3); /* ret */
> +    tcg_out_opc(s, OPC_RET);
>  }
>  
>  void tcg_target_init(TCGContext *s)
> -- 
> 1.6.6.1
> 
> 
> 
> 

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net