From: Aurelien Jarno <aurelien@aurel32.net>
To: Rabin Vincent <rabin@rab.in>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/2] arm_timer: fix oneshot mode
Date: Fri, 21 May 2010 12:00:49 +0200 [thread overview]
Message-ID: <20100521100049.GD23891@volta.aurel32.net> (raw)
In-Reply-To: <1272793852-26260-2-git-send-email-rabin@rab.in>
On Sun, May 02, 2010 at 03:20:52PM +0530, Rabin Vincent wrote:
> In oneshot mode, the delta needs to come from the TimerLoad register,
> not the maximum limit.
>
> Signed-off-by: Rabin Vincent <rabin@rab.in>
Thanks, applied.
> ---
> hw/arm_timer.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/hw/arm_timer.c b/hw/arm_timer.c
> index 5b6947a..9073ffc 100644
> --- a/hw/arm_timer.c
> +++ b/hw/arm_timer.c
> @@ -71,7 +71,7 @@ static void arm_timer_recalibrate(arm_timer_state *s, int reload)
> {
> uint32_t limit;
>
> - if ((s->control & TIMER_CTRL_PERIODIC) == 0) {
> + if ((s->control & (TIMER_CTRL_PERIODIC | TIMER_CTRL_ONESHOT)) == 0) {
> /* Free running. */
> if (s->control & TIMER_CTRL_32BIT)
> limit = 0xffffffff;
> --
> 1.7.0.4
>
>
>
>
--
Aurelien Jarno GPG: 1024D/F1BCDB73
aurelien@aurel32.net http://www.aurel32.net
next prev parent reply other threads:[~2010-05-21 10:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-02 9:50 [Qemu-devel] [PATCH 1/2] arm_timer: reload timer when enabled Rabin Vincent
2010-05-02 9:50 ` [Qemu-devel] [PATCH 2/2] arm_timer: fix oneshot mode Rabin Vincent
2010-05-21 10:00 ` Aurelien Jarno [this message]
2010-05-20 17:27 ` [Qemu-devel] Re: [PATCH 1/2] arm_timer: reload timer when enabled Rabin Vincent
2010-05-21 10:00 ` [Qemu-devel] " Aurelien Jarno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100521100049.GD23891@volta.aurel32.net \
--to=aurelien@aurel32.net \
--cc=qemu-devel@nongnu.org \
--cc=rabin@rab.in \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).