From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=33921 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OFVNB-0005U2-4k for qemu-devel@nongnu.org; Fri, 21 May 2010 12:46:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OFVN9-0007NB-4p for qemu-devel@nongnu.org; Fri, 21 May 2010 12:46:56 -0400 Received: from hall.aurel32.net ([88.191.82.174]:59618) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OFVN8-0007N1-W8 for qemu-devel@nongnu.org; Fri, 21 May 2010 12:46:55 -0400 Date: Fri, 21 May 2010 18:46:41 +0200 From: Aurelien Jarno Subject: Re: [Qemu-devel] [PATCH] [S390] Remove warning in tcg stub (tcg_out_reloc) Message-ID: <20100521164641.GA4989@volta.aurel32.net> References: <1273595012-19587-1-git-send-email-agraf@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <1273595012-19587-1-git-send-email-agraf@suse.de> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: qemu-devel@nongnu.org On Tue, May 11, 2010 at 06:23:32PM +0200, Alexander Graf wrote: > On S390 we don't have a real TCG implementation but use a stub instead. This > stub obviously doesn't call any of the TCG helper functions that are usually > used by the other TCG targets. > > If such a helper function is static though, we end up getting a warning that > turns into an error thanks to Werror. So to successfully compile qemu, we need > to get rid of it. In this case it's tcg_out_reloc. > > To do that, I figured the easiest way is to call tcg_out_reloc with dumb > parameters after an abort call. That way the code in question never gets > executed, but we got rid of the warning. > > Signed-off-by: Alexander Graf > --- > tcg/s390/tcg-target.c | 6 ++++++ > 1 files changed, 6 insertions(+), 0 deletions(-) > > diff --git a/tcg/s390/tcg-target.c b/tcg/s390/tcg-target.c > index 265194a..f1a336d 100644 > --- a/tcg/s390/tcg-target.c > +++ b/tcg/s390/tcg-target.c > @@ -35,6 +35,12 @@ static void patch_reloc(uint8_t *code_ptr, int type, > tcg_target_long value, tcg_target_long addend) > { > tcg_abort(); > + > + /* > + * XXX We need to call this function at least once, since it's static. > + * Please remove that code when implementing real s390x tcg support. > + */ > + tcg_out_reloc(NULL, NULL, 0, 0, 0); > } > What about declaring tcg_out_reloc static inline? -- Aurelien Jarno GPG: 1024D/F1BCDB73 aurelien@aurel32.net http://www.aurel32.net