From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=54197 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OGX8G-0003kL-Pz for qemu-devel@nongnu.org; Mon, 24 May 2010 08:51:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OGX7z-0006mr-LN for qemu-devel@nongnu.org; Mon, 24 May 2010 08:51:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58350) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OGX7y-0006m8-Um for qemu-devel@nongnu.org; Mon, 24 May 2010 08:51:31 -0400 Date: Mon, 24 May 2010 09:51:18 -0300 From: Luiz Capitulino Message-ID: <20100524095118.539f2b9e@redhat.com> In-Reply-To: <4BF8DFF7.5070302@web.de> References: <1f557b9feb1965a61e64f7166bcf4918bed8d0ec.1274516288.git.jan.kiszka@web.de> <4BF82895.6000706@redhat.com> <4BF8DFF7.5070302@web.de> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH v2 12/15] monitor: Add basic device state visualization List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: Anthony Liguori , Juan Quintela , Jan Kiszka , Markus Armbruster , qemu-devel@nongnu.org, Avi Kivity On Sun, 23 May 2010 09:57:43 +0200 Jan Kiszka wrote: > Avi Kivity wrote: [...] > > > >> +- "full": report full state (json-bool, optional) > >> > > > > Is this needed for QMP? The client can always truncate it to any length. > > The effect may not be needed for QMP, but I do need this channel from > the command line to the monitor pretty-printer. I could just stick > "full": json-bool back into the return dict, but that would look somehow > strange IMO. We could have a form of optional key which is only present internally, we have that async commands.