From: Paul Brook <paul@codesourcery.com>
To: Juan Quintela <quintela@redhat.com>
Cc: Blue Swirl <blauwirbel@gmail.com>, Jan Kiszka <jan.kiszka@web.de>,
qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH 0/6] Make hpet a compile time option
Date: Mon, 24 May 2010 17:32:46 +0100 [thread overview]
Message-ID: <201005241732.46988.paul@codesourcery.com> (raw)
In-Reply-To: <m3hblxwawb.fsf@trasno.mitica>
> Notice that this patch was sent against hpet as one example, if we agree
> that this "way" of disabling devices is ok, we could disable more
> devices/have more flexibility. Notice that in general, we (RHEL/KVM)
> are interested in a small subset of qemu devices.
IMO this patch is a backwards step. The device models should be cleaned up so
that you don't need to make a compile time decision. You'll notice that a
fair amount of effort has been put into making the device/system code less
tightly coupled and less machine specific. All inter-device interaction and
links should be explicit. Changing from "PC with HPET" and "PC without HPET"
should not require recompiling anything, and devices shouldn't need to know or
care which they're part of.
Paul
next prev parent reply other threads:[~2010-05-24 16:33 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-24 15:18 [Qemu-devel] [PATCH 0/6] Make hpet a compile time option Juan Quintela
2010-05-24 15:18 ` [Qemu-devel] [PATCH 1/6] Create again config-device.h and config.devices.h Juan Quintela
2010-05-24 15:18 ` [Qemu-devel] [PATCH 2/6] Move no_hpet declaration to hpet_emul.h Juan Quintela
2010-05-24 15:18 ` [Qemu-devel] [PATCH 3/6] Move no_hpet test to inside hpet_init() Juan Quintela
2010-05-24 15:18 ` [Qemu-devel] [PATCH 4/6] Make hpet_in_legacy_mode() return 0 for !TARGET_I386 Juan Quintela
2010-05-24 15:18 ` [Qemu-devel] [PATCH 5/6] make hpet_in_legacy_mode() return a bool Juan Quintela
2010-05-24 15:18 ` [Qemu-devel] [PATCH 6/6] Create CONFIG_HPET Juan Quintela
2010-05-24 15:20 ` [Qemu-devel] Re: [PATCH 0/6] Make hpet a compile time option Juan Quintela
2010-05-24 15:43 ` Jan Kiszka
2010-05-24 15:57 ` Juan Quintela
2010-05-24 16:20 ` Jan Kiszka
2010-05-24 18:08 ` Juan Quintela
2010-05-24 20:11 ` Jan Kiszka
2010-05-24 16:32 ` Paul Brook [this message]
2010-05-24 16:49 ` Anthony Liguori
2010-05-24 17:11 ` Paul Brook
2010-05-24 17:37 ` Anthony Liguori
2010-05-24 17:54 ` Juan Quintela
2010-05-24 18:03 ` Anthony Liguori
2010-05-24 18:15 ` Jan Kiszka
2010-05-24 20:16 ` Blue Swirl
2010-05-24 18:10 ` Jan Kiszka
2010-05-25 8:38 ` Paolo Bonzini
2010-05-25 9:05 ` Jan Kiszka
2010-05-25 9:56 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201005241732.46988.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=blauwirbel@gmail.com \
--cc=jan.kiszka@web.de \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).