From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=35140 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OGaaV-0002oy-OM for qemu-devel@nongnu.org; Mon, 24 May 2010 12:33:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OGaaT-0003H1-51 for qemu-devel@nongnu.org; Mon, 24 May 2010 12:33:11 -0400 Received: from mail.codesourcery.com ([38.113.113.100]:38197) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OGaaS-0003Gj-P0 for qemu-devel@nongnu.org; Mon, 24 May 2010 12:33:09 -0400 From: Paul Brook Date: Mon, 24 May 2010 17:32:46 +0100 References: <4BFA9E8C.2070602@web.de> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201005241732.46988.paul@codesourcery.com> Subject: [Qemu-devel] Re: [PATCH 0/6] Make hpet a compile time option List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela Cc: Blue Swirl , Jan Kiszka , qemu-devel@nongnu.org > Notice that this patch was sent against hpet as one example, if we agree > that this "way" of disabling devices is ok, we could disable more > devices/have more flexibility. Notice that in general, we (RHEL/KVM) > are interested in a small subset of qemu devices. IMO this patch is a backwards step. The device models should be cleaned up so that you don't need to make a compile time decision. You'll notice that a fair amount of effort has been put into making the device/system code less tightly coupled and less machine specific. All inter-device interaction and links should be explicit. Changing from "PC with HPET" and "PC without HPET" should not require recompiling anything, and devices shouldn't need to know or care which they're part of. Paul