From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=35231 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OGbBj-00057Y-P5 for qemu-devel@nongnu.org; Mon, 24 May 2010 13:11:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OGbBc-00006J-R5 for qemu-devel@nongnu.org; Mon, 24 May 2010 13:11:39 -0400 Received: from mail.codesourcery.com ([38.113.113.100]:39339) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OGbBc-00006A-CV for qemu-devel@nongnu.org; Mon, 24 May 2010 13:11:32 -0400 From: Paul Brook Subject: Re: [Qemu-devel] Re: [PATCH 0/6] Make hpet a compile time option Date: Mon, 24 May 2010 18:11:09 +0100 References: <201005241732.46988.paul@codesourcery.com> <4BFAAE22.5040900@codemonkey.ws> In-Reply-To: <4BFAAE22.5040900@codemonkey.ws> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201005241811.10219.paul@codesourcery.com> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Blue Swirl , Jan Kiszka , qemu-devel@nongnu.org, Juan Quintela > On 05/24/2010 11:32 AM, Paul Brook wrote: > >> Notice that this patch was sent against hpet as one example, if we agree > >> that this "way" of disabling devices is ok, we could disable more > >> devices/have more flexibility. Notice that in general, we (RHEL/KVM) > >> are interested in a small subset of qemu devices. > > > > IMO this patch is a backwards step. The device models should be cleaned > > up so that you don't need to make a compile time decision. > > I disagree. I think the device model should be cleaned up so that no > CONFIG_HPET is required in code but I think it's still useful to be able > to exclude device models from the build. That should just be a matter > of not building the object though (that's the point of device_init()). I think we're saying the same thing. We already have a mechanism for avoiding things at build time - specifically config-devices.mak. We don't have a nice UI for it, but it's there. At worst your distro specific patch is a 1-line change to default- configs/i386-softmmu.mak. I have no objection to moving hpet.c into Makefile.objs, conditional on CONFIG_HPET (like e.g. CONFIG_SERIAL/serial.o). However a necessary prerequisite is that you fix the device model and machine initialisation so that it's possible to omit hpet.o without rebuilding anything else. Paul