From: Joerg Roedel <joro@8bytes.org>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel@nongnu.org, aliguori@us.ibm.com, avi@redhat.com,
kvm@vger.kernel.org,
Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro>
Subject: Re: [Qemu-devel] Re: [RFC PATCH] AMD IOMMU emulation
Date: Tue, 25 May 2010 10:39:22 +0200 [thread overview]
Message-ID: <20100525083922.GF1237@8bytes.org> (raw)
In-Reply-To: <AANLkTikMObCmMYdW25iVNi1d0xF3rRm9tBLQ37dhwUMD@mail.gmail.com>
On Mon, May 24, 2010 at 08:10:16PM +0000, Blue Swirl wrote:
> On Mon, May 24, 2010 at 3:40 PM, Joerg Roedel <joro@8bytes.org> wrote:
> >> +
> >> +#define MMIO_SIZE 0x2028
> >
> > This size should be a power-of-two value. In this case probably 0x4000.
>
> Not really, the devices can reserve regions of any size. There were
> some implementation deficiencies in earlier versions of QEMU, where
> the whole page would be reserved anyway, but this limitation has been
> removed long time ago.
The drivers for AMD IOMMU expect that to be 0x4000. At least the Linux
driver maps the MMIO region with this size. So the emulation should
reserve this amount of MMIO space too.
Joerg
next prev parent reply other threads:[~2010-05-25 8:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-20 13:50 [Qemu-devel] [RFC PATCH] AMD IOMMU emulation Eduard - Gabriel Munteanu
2010-05-24 15:40 ` [Qemu-devel] " Joerg Roedel
2010-05-24 20:10 ` Blue Swirl
2010-05-25 8:39 ` Joerg Roedel [this message]
2010-05-25 11:23 ` Eduard - Gabriel Munteanu
2010-05-25 19:16 ` Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100525083922.GF1237@8bytes.org \
--to=joro@8bytes.org \
--cc=aliguori@us.ibm.com \
--cc=avi@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=eduard.munteanu@linux360.ro \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).