From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=48140 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OGpfZ-0002nd-RV
	for qemu-devel@nongnu.org; Tue, 25 May 2010 04:39:26 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <joro@8bytes.org>) id 1OGpfY-0003TL-E9
	for qemu-devel@nongnu.org; Tue, 25 May 2010 04:39:25 -0400
Received: from 8bytes.org ([88.198.83.132]:57337)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <joro@8bytes.org>) id 1OGpfY-0003T6-8G
	for qemu-devel@nongnu.org; Tue, 25 May 2010 04:39:24 -0400
Date: Tue, 25 May 2010 10:39:22 +0200
From: Joerg Roedel <joro@8bytes.org>
Subject: Re: [Qemu-devel] Re: [RFC PATCH] AMD IOMMU emulation
Message-ID: <20100525083922.GF1237@8bytes.org>
References: <1274363407-24862-1-git-send-email-eduard.munteanu@linux360.ro>
	<20100524154030.GE1237@8bytes.org>
	<AANLkTikMObCmMYdW25iVNi1d0xF3rRm9tBLQ37dhwUMD@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <AANLkTikMObCmMYdW25iVNi1d0xF3rRm9tBLQ37dhwUMD@mail.gmail.com>
Content-Transfer-Encoding: quoted-printable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel@nongnu.org, aliguori@us.ibm.com, avi@redhat.com, kvm@vger.kernel.org, Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro>

On Mon, May 24, 2010 at 08:10:16PM +0000, Blue Swirl wrote:
> On Mon, May 24, 2010 at 3:40 PM, Joerg Roedel <joro@8bytes.org> wrote:
> >> +
> >> +#define MMIO_SIZE =A0 =A0 =A0 =A0 =A0 =A0 =A0 0x2028
> >
> > This size should be a power-of-two value. In this case probably 0x400=
0.
>=20
> Not really, the devices can reserve regions of any size. There were
> some implementation deficiencies in earlier versions of QEMU, where
> the whole page would be reserved anyway, but this limitation has been
> removed long time ago.

The drivers for AMD IOMMU expect that to be 0x4000. At least the Linux
driver maps the MMIO region with this size. So the emulation should
reserve this amount of MMIO space too.

	Joerg