From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=37087 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OGqSk-0008Df-RD
	for qemu-devel@nongnu.org; Tue, 25 May 2010 05:30:20 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <paul@codesourcery.com>) id 1OGqSj-0001eZ-QO
	for qemu-devel@nongnu.org; Tue, 25 May 2010 05:30:14 -0400
Received: from mail.codesourcery.com ([38.113.113.100]:39561)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <paul@codesourcery.com>) id 1OGqSj-0001eD-Hh
	for qemu-devel@nongnu.org; Tue, 25 May 2010 05:30:13 -0400
From: Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] [RFT][PATCH 09/15] hpet/rtc: Rework RTC IRQ
	replacement by HPET
Date: Tue, 25 May 2010 10:29:48 +0100
References: <cover.1274732025.git.jan.kiszka@web.de>
	<b46a7c542c3b0b5e6f800d966b31f21672c6cae9.1274732025.git.jan.kiszka@web.de>
In-Reply-To: <b46a7c542c3b0b5e6f800d966b31f21672c6cae9.1274732025.git.jan.kiszka@web.de>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Message-Id: <201005251029.49089.paul@codesourcery.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: blue Swirl <blauwirbel@gmail.com>, Jan Kiszka <jan.kiszka@siemens.com>, Jan Kiszka <jan.kiszka@web.de>, Juan Quintela <quintela@redhat.com>

>          for (i = 0; i < 24; i++) {
>              sysbus_connect_irq(sysbus_from_qdev(hpet), i, isa_irq[i]);
>          }
> +        rtc_irq = qemu_allocate_feedback_irqs(hpet_handle_rtc_irq,
> +                                              sysbus_from_qdev(hpet), 1);
>      }

This is wrong. The hpet device should expose this as an IO pin.

Paul