From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=56333 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OGqaT-0002vp-DZ
	for qemu-devel@nongnu.org; Tue, 25 May 2010 05:38:14 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <paul@codesourcery.com>) id 1OGqaL-0002bc-OL
	for qemu-devel@nongnu.org; Tue, 25 May 2010 05:38:13 -0400
Received: from mail.codesourcery.com ([38.113.113.100]:49561)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <paul@codesourcery.com>) id 1OGqaL-0002bK-Gl
	for qemu-devel@nongnu.org; Tue, 25 May 2010 05:38:05 -0400
From: Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] [RFT][PATCH 05/15] hpet: Convert to qdev
Date: Tue, 25 May 2010 10:37:41 +0100
References: <cover.1274732025.git.jan.kiszka@web.de>
	<3d07ca44a4c2332d3f6247033031e891d3678804.1274732025.git.jan.kiszka@web.de>
In-Reply-To: <3d07ca44a4c2332d3f6247033031e891d3678804.1274732025.git.jan.kiszka@web.de>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Message-Id: <201005251037.41646.paul@codesourcery.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: blue Swirl <blauwirbel@gmail.com>, Jan Kiszka <jan.kiszka@siemens.com>, Jan Kiszka <jan.kiszka@web.de>, Juan Quintela <quintela@redhat.com>

> +static SysBusDeviceInfo hpet_device_info = {
> +    .qdev.name    = "hpet",
> +    .qdev.size    = sizeof(HPETState),
> +    .qdev.no_user = 1,

Why shouldn't the user create HPET devices? I thought you'd removed all the 
global state.

Paul