From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=51408 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OGsFG-0001hm-Au
	for qemu-devel@nongnu.org; Tue, 25 May 2010 07:24:27 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <edgmnt@gmail.com>) id 1OGsFF-0002Dy-6c
	for qemu-devel@nongnu.org; Tue, 25 May 2010 07:24:26 -0400
Received: from mail-fx0-f45.google.com ([209.85.161.45]:50645)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <edgmnt@gmail.com>) id 1OGsFF-0002Do-2K
	for qemu-devel@nongnu.org; Tue, 25 May 2010 07:24:25 -0400
Received: by fxm10 with SMTP id 10so256894fxm.4
	for <qemu-devel@nongnu.org>; Tue, 25 May 2010 04:24:23 -0700 (PDT)
Sender: Eduard - Gabriel Munteanu <edgmnt@gmail.com>
Date: Tue, 25 May 2010 14:23:51 +0300
From: Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro>
Subject: Re: [Qemu-devel] Re: [RFC PATCH] AMD IOMMU emulation
Message-ID: <20100525112351.GA6234@localhost>
References: <1274363407-24862-1-git-send-email-eduard.munteanu@linux360.ro>
	<20100524154030.GE1237@8bytes.org>
	<AANLkTikMObCmMYdW25iVNi1d0xF3rRm9tBLQ37dhwUMD@mail.gmail.com>
	<20100525083922.GF1237@8bytes.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20100525083922.GF1237@8bytes.org>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Joerg Roedel <joro@8bytes.org>
Cc: Blue Swirl <blauwirbel@gmail.com>, aliguori@us.ibm.com, avi@redhat.com, kvm@vger.kernel.org, qemu-devel@nongnu.org

On Tue, May 25, 2010 at 10:39:22AM +0200, Joerg Roedel wrote:
> On Mon, May 24, 2010 at 08:10:16PM +0000, Blue Swirl wrote:
> > On Mon, May 24, 2010 at 3:40 PM, Joerg Roedel <joro@8bytes.org> wrote:
> > >> +
> > >> +#define MMIO_SIZE ? ? ? ? ? ? ? 0x2028
> > >
> > > This size should be a power-of-two value. In this case probably 0x4000.
> > 
> > Not really, the devices can reserve regions of any size. There were
> > some implementation deficiencies in earlier versions of QEMU, where
> > the whole page would be reserved anyway, but this limitation has been
> > removed long time ago.
> 
> The drivers for AMD IOMMU expect that to be 0x4000. At least the Linux
> driver maps the MMIO region with this size. So the emulation should
> reserve this amount of MMIO space too.
> 
> 	Joerg

Yeah, I'll change that, since I already reserve 0x4000 bytes in SeaBIOS
for it (I did that to deal with the 16 KiB alignment requirement).


	Eduard