From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=45741 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OGydH-00086A-37 for qemu-devel@nongnu.org; Tue, 25 May 2010 14:13:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OGydF-0008EG-Of for qemu-devel@nongnu.org; Tue, 25 May 2010 14:13:39 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46277) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OGydF-0008EA-Ca for qemu-devel@nongnu.org; Tue, 25 May 2010 14:13:37 -0400 Date: Tue, 25 May 2010 15:13:24 -0300 From: Luiz Capitulino Message-ID: <20100525151324.095fa894@redhat.com> In-Reply-To: <4BFBF66F.3030702@codemonkey.ws> References: <9b6575587d22a5c85ec536172810520ee3b945d5.1274796992.git.quintela@redhat.com> <4BFBE843.5070202@codemonkey.ws> <4BFBF36D.8070208@codemonkey.ws> <4BFBF66F.3030702@codemonkey.ws> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 3/5] QMP: Introduce MIGRATION events List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Markus@gnu.org, qemu-devel@nongnu.org, Armbruster , Juan Quintela On Tue, 25 May 2010 11:10:23 -0500 Anthony Liguori wrote: > >>>> There should be some information about why it failed, no? Preferrably > >>>> in a QError format. > >>>> > >>>> > >>> At this point, we have basically -1 :( > >>> > >>> I can add a field with an error number, but we are very bad at the > >>> moment about moving errno's upstack. > >>> > >>> > >> We need a better solution for reporting errors via notifications. > >> > > Suggestions? > > > > Notice that what we need now is a way to know if migration ended with > > success or in any other way, as soon as possible. > > > > Markus/Luiz? We need to redesign QError. I could give it a try, but quite frankly, I don't know how do it good enough.. Markus has worked more on error handling than me though and I think he's the best person to do it, but he's busy at other things atm. Note that major work is design, not code churn (could turn out into an issue, but I doubt it).