From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=53603 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OGwQu-0001yU-Sk
	for qemu-devel@nongnu.org; Tue, 25 May 2010 11:52:46 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <berrange@redhat.com>) id 1OGwQt-0005vH-J5
	for qemu-devel@nongnu.org; Tue, 25 May 2010 11:52:44 -0400
Received: from mx1.redhat.com ([209.132.183.28]:36324)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <berrange@redhat.com>) id 1OGwQt-0005v7-C8
	for qemu-devel@nongnu.org; Tue, 25 May 2010 11:52:43 -0400
Date: Tue, 25 May 2010 16:52:37 +0100
From: "Daniel P. Berrange" <berrange@redhat.com>
Subject: Re: [Qemu-devel] Re: [PATCH 3/5] QMP: Introduce MIGRATION events
Message-ID: <20100525155237.GO31759@redhat.com>
References: <cover.1274796992.git.quintela@redhat.com>
	<9b6575587d22a5c85ec536172810520ee3b945d5.1274796992.git.quintela@redhat.com>
	<4BFBE843.5070202@codemonkey.ws> <m34ohwhu3q.fsf@trasno.mitica>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <m34ohwhu3q.fsf@trasno.mitica>
Reply-To: "Daniel P. Berrange" <berrange@redhat.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Juan Quintela <quintela@redhat.com>
Cc: qemu-devel@nongnu.org

On Tue, May 25, 2010 at 05:35:53PM +0200, Juan Quintela wrote:
> Anthony Liguori <anthony@codemonkey.ws> wrote:
> 
> >> +Example:
> >> +
> >> +{ "event": "MIGRATION_FAILED",
> >> +    "timestamp": {"seconds": 1274687575, "microseconds": 592483} }
> >> +
> >> +MIGRATION_STARTED
> >> +-----------------
> >> +
> >> +Emitted when migration starts (both in source and target).
> >>    
> >
> > I think this makes more sense as a MIGRATION_CONNECTED event.  It
> > probably should carry peer information too.
> 
> What kind of peer information?
> 
> We have tcp/fd/exec/unix migrations.  calling it CONNECTED vs STARTED, I
> don't care.  But adding information?  Notice that the management
> application knows what it did, I can put the:
> 
>  "exec: gzip -d < /tmp/foo"
> 
> string, but not much more that I can put here.

This is why I think network client CONNECT/DISCONNECT events should be
separate from MIGRATION START/END events. They happen to occur at roughly
the same time if using a TCP / UNIX socket based migration transport,
but CONNECT/DISCONNECT + peer info is meaningless for exec or fd based
migration.


Daniel
-- 
|: Red Hat, Engineering, London    -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://deltacloud.org :|
|: http://autobuild.org        -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|