From: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] posix-aio-compat: Expand tabs that have crept in
Date: Thu, 27 May 2010 14:12:33 +0100 [thread overview]
Message-ID: <20100527131233.GA3584@stefan-thinkpad.transitives.com> (raw)
In-Reply-To: <4BFE6AAE.7060707@redhat.com>
On Thu, May 27, 2010 at 02:50:54PM +0200, Kevin Wolf wrote:
> I'm usually not a big supporter of patches that only change style, but
> tabs are nasty and you can ignore these whitespace changes in git blame
> at least, so for all I care let's take it for once.
Interesting, I tend to prefer separate code change and whitespace change
patches. It's hard to review a patch that combines code and whitespace
changes because you have to manually compare the touched lines to see
what, if anything, has changed.
Is this the policy across all of QEMU or your preference for
block-related code? I'll try to follow it for that area in the future.
Thanks,
Stefan
next prev parent reply other threads:[~2010-05-27 13:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-27 11:52 [Qemu-devel] [PATCH] posix-aio-compat: Expand tabs that have crept in Stefan Hajnoczi
2010-05-27 12:50 ` Kevin Wolf
2010-05-27 13:12 ` Stefan Hajnoczi [this message]
2010-05-27 13:46 ` Kevin Wolf
2010-05-27 14:12 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100527131233.GA3584@stefan-thinkpad.transitives.com \
--to=stefanha@linux.vnet.ibm.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).