From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=33318 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OHct9-0004rt-U0
	for qemu-devel@nongnu.org; Thu, 27 May 2010 09:12:44 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <stefanha@linux.vnet.ibm.com>) id 1OHct5-0003nx-2E
	for qemu-devel@nongnu.org; Thu, 27 May 2010 09:12:43 -0400
Received: from mtagate3.uk.ibm.com ([194.196.100.163]:36802)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <stefanha@linux.vnet.ibm.com>) id 1OHct4-0003nM-R1
	for qemu-devel@nongnu.org; Thu, 27 May 2010 09:12:39 -0400
Received: from d06nrmr1407.portsmouth.uk.ibm.com
	(d06nrmr1407.portsmouth.uk.ibm.com [9.149.38.185])
	by mtagate3.uk.ibm.com (8.13.1/8.13.1) with ESMTP id o4RDCYLb028568
	for <qemu-devel@nongnu.org>; Thu, 27 May 2010 13:12:34 GMT
Received: from d06av04.portsmouth.uk.ibm.com (d06av04.portsmouth.uk.ibm.com
	[9.149.37.216])
	by d06nrmr1407.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with
	ESMTP id o4RDCYGh667684
	for <qemu-devel@nongnu.org>; Thu, 27 May 2010 14:12:34 +0100
Received: from d06av04.portsmouth.uk.ibm.com (loopback [127.0.0.1])
	by d06av04.portsmouth.uk.ibm.com (8.12.11.20060308/8.13.3) with ESMTP
	id o4RDCYR7029009
	for <qemu-devel@nongnu.org>; Thu, 27 May 2010 14:12:34 +0100
Date: Thu, 27 May 2010 14:12:33 +0100
From: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH] posix-aio-compat: Expand tabs that have
	crept	in
Message-ID: <20100527131233.GA3584@stefan-thinkpad.transitives.com>
References: <1274961128-3358-1-git-send-email-stefanha@linux.vnet.ibm.com>
	<4BFE6AAE.7060707@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4BFE6AAE.7060707@redhat.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org

On Thu, May 27, 2010 at 02:50:54PM +0200, Kevin Wolf wrote:
> I'm usually not a big supporter of patches that only change style, but
> tabs are nasty and you can ignore these whitespace changes in git blame
> at least, so for all I care let's take it for once.

Interesting, I tend to prefer separate code change and whitespace change
patches.  It's hard to review a patch that combines code and whitespace
changes because you have to manually compare the touched lines to see
what, if anything, has changed.

Is this the policy across all of QEMU or your preference for
block-related code?  I'll try to follow it for that area in the future.

Thanks,
Stefan