From: "Michael S. Tsirkin" <mst@redhat.com>
To: Isaku Yamahata <yamahata@valinux.co.jp>
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH] pci.h: remove unused constants.
Date: Thu, 27 May 2010 17:14:37 +0300 [thread overview]
Message-ID: <20100527141437.GD8287@redhat.com> (raw)
In-Reply-To: <20100527054002.GE31807@valinux.co.jp>
On Thu, May 27, 2010 at 02:40:02PM +0900, Isaku Yamahata wrote:
> So remove unused constants,
> PCI_STATUS_RESERVED_MASK_LO, PCI_STATUS_RESERVED_MASK_HI,
> PCI_COMMAND_RESERVED, PCI_COMMAND_RESERVED_MASK_HI.
> They were used once, but they aren't used anymore.
>
> Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>
Applied, thanks!
Also, please cc me on patches.
> ---
> hw/pci.h | 11 -----------
> 1 files changed, 0 insertions(+), 11 deletions(-)
>
> diff --git a/hw/pci.h b/hw/pci.h
> index f6e6c5f..6eee93a 100644
> --- a/hw/pci.h
> +++ b/hw/pci.h
> @@ -97,17 +97,6 @@ typedef struct PCIIORegion {
> /* PCI HEADER_TYPE */
> #define PCI_HEADER_TYPE_MULTI_FUNCTION 0x80
>
> -#define PCI_STATUS_RESERVED_MASK_LO (PCI_STATUS_RESERVED1 | \
> - PCI_STATUS_INT_STATUS | PCI_STATUS_CAPABILITIES | \
> - PCI_STATUS_66MHZ | PCI_STATUS_RESERVED2 | PCI_STATUS_FAST_BACK)
> -
> -#define PCI_STATUS_RESERVED_MASK_HI (PCI_STATUS_DEVSEL >> 8)
> -
> -/* Bits in the PCI Command Register (PCI 2.3 spec) */
> -#define PCI_COMMAND_RESERVED 0xf800
> -
> -#define PCI_COMMAND_RESERVED_MASK_HI (PCI_COMMAND_RESERVED >> 8)
> -
> /* Size of the standard PCI config header */
> #define PCI_CONFIG_HEADER_SIZE 0x40
> /* Size of the standard PCI config space */
> --
> 1.6.6.1
>
prev parent reply other threads:[~2010-05-27 14:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-27 5:40 [Qemu-devel] [PATCH] pci.h: remove unused constants Isaku Yamahata
2010-05-27 14:14 ` Michael S. Tsirkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100527141437.GD8287@redhat.com \
--to=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=yamahata@valinux.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).