* [Qemu-devel] [PATCH] pci.h: remove unused constants.
@ 2010-05-27 5:40 Isaku Yamahata
2010-05-27 14:14 ` [Qemu-devel] " Michael S. Tsirkin
0 siblings, 1 reply; 2+ messages in thread
From: Isaku Yamahata @ 2010-05-27 5:40 UTC (permalink / raw)
To: qemu-devel
So remove unused constants,
PCI_STATUS_RESERVED_MASK_LO, PCI_STATUS_RESERVED_MASK_HI,
PCI_COMMAND_RESERVED, PCI_COMMAND_RESERVED_MASK_HI.
They were used once, but they aren't used anymore.
Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>
---
hw/pci.h | 11 -----------
1 files changed, 0 insertions(+), 11 deletions(-)
diff --git a/hw/pci.h b/hw/pci.h
index f6e6c5f..6eee93a 100644
--- a/hw/pci.h
+++ b/hw/pci.h
@@ -97,17 +97,6 @@ typedef struct PCIIORegion {
/* PCI HEADER_TYPE */
#define PCI_HEADER_TYPE_MULTI_FUNCTION 0x80
-#define PCI_STATUS_RESERVED_MASK_LO (PCI_STATUS_RESERVED1 | \
- PCI_STATUS_INT_STATUS | PCI_STATUS_CAPABILITIES | \
- PCI_STATUS_66MHZ | PCI_STATUS_RESERVED2 | PCI_STATUS_FAST_BACK)
-
-#define PCI_STATUS_RESERVED_MASK_HI (PCI_STATUS_DEVSEL >> 8)
-
-/* Bits in the PCI Command Register (PCI 2.3 spec) */
-#define PCI_COMMAND_RESERVED 0xf800
-
-#define PCI_COMMAND_RESERVED_MASK_HI (PCI_COMMAND_RESERVED >> 8)
-
/* Size of the standard PCI config header */
#define PCI_CONFIG_HEADER_SIZE 0x40
/* Size of the standard PCI config space */
--
1.6.6.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Qemu-devel] Re: [PATCH] pci.h: remove unused constants.
2010-05-27 5:40 [Qemu-devel] [PATCH] pci.h: remove unused constants Isaku Yamahata
@ 2010-05-27 14:14 ` Michael S. Tsirkin
0 siblings, 0 replies; 2+ messages in thread
From: Michael S. Tsirkin @ 2010-05-27 14:14 UTC (permalink / raw)
To: Isaku Yamahata; +Cc: qemu-devel
On Thu, May 27, 2010 at 02:40:02PM +0900, Isaku Yamahata wrote:
> So remove unused constants,
> PCI_STATUS_RESERVED_MASK_LO, PCI_STATUS_RESERVED_MASK_HI,
> PCI_COMMAND_RESERVED, PCI_COMMAND_RESERVED_MASK_HI.
> They were used once, but they aren't used anymore.
>
> Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>
Applied, thanks!
Also, please cc me on patches.
> ---
> hw/pci.h | 11 -----------
> 1 files changed, 0 insertions(+), 11 deletions(-)
>
> diff --git a/hw/pci.h b/hw/pci.h
> index f6e6c5f..6eee93a 100644
> --- a/hw/pci.h
> +++ b/hw/pci.h
> @@ -97,17 +97,6 @@ typedef struct PCIIORegion {
> /* PCI HEADER_TYPE */
> #define PCI_HEADER_TYPE_MULTI_FUNCTION 0x80
>
> -#define PCI_STATUS_RESERVED_MASK_LO (PCI_STATUS_RESERVED1 | \
> - PCI_STATUS_INT_STATUS | PCI_STATUS_CAPABILITIES | \
> - PCI_STATUS_66MHZ | PCI_STATUS_RESERVED2 | PCI_STATUS_FAST_BACK)
> -
> -#define PCI_STATUS_RESERVED_MASK_HI (PCI_STATUS_DEVSEL >> 8)
> -
> -/* Bits in the PCI Command Register (PCI 2.3 spec) */
> -#define PCI_COMMAND_RESERVED 0xf800
> -
> -#define PCI_COMMAND_RESERVED_MASK_HI (PCI_COMMAND_RESERVED >> 8)
> -
> /* Size of the standard PCI config header */
> #define PCI_CONFIG_HEADER_SIZE 0x40
> /* Size of the standard PCI config space */
> --
> 1.6.6.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-05-27 14:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-05-27 5:40 [Qemu-devel] [PATCH] pci.h: remove unused constants Isaku Yamahata
2010-05-27 14:14 ` [Qemu-devel] " Michael S. Tsirkin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).