From: "Michael S. Tsirkin" <mst@redhat.com>
To: Isaku Yamahata <yamahata@valinux.co.jp>
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH] msix: remove duplicated defines.
Date: Thu, 27 May 2010 17:15:07 +0300 [thread overview]
Message-ID: <20100527141507.GE8287@redhat.com> (raw)
In-Reply-To: <20100527054037.GF31807@valinux.co.jp>
On Thu, May 27, 2010 at 02:40:37PM +0900, Isaku Yamahata wrote:
> remove defines which are already defined in pci_regs.h
>
> Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>
Applied, thanks!
> ---
> hw/msix.c | 8 --------
> 1 files changed, 0 insertions(+), 8 deletions(-)
>
> diff --git a/hw/msix.c b/hw/msix.c
> index 2ca0900..1613bb4 100644
> --- a/hw/msix.c
> +++ b/hw/msix.c
> @@ -15,14 +15,6 @@
> #include "msix.h"
> #include "pci.h"
>
> -/* Declaration from linux/pci_regs.h */
> -#define PCI_CAP_ID_MSIX 0x11 /* MSI-X */
> -#define PCI_MSIX_FLAGS 2 /* Table at lower 11 bits */
> -#define PCI_MSIX_FLAGS_QSIZE 0x7FF
> -#define PCI_MSIX_FLAGS_ENABLE (1 << 15)
> -#define PCI_MSIX_FLAGS_MASKALL (1 << 14)
> -#define PCI_MSIX_FLAGS_BIRMASK (7 << 0)
> -
> /* MSI-X capability structure */
> #define MSIX_TABLE_OFFSET 4
> #define MSIX_PBA_OFFSET 8
> --
> 1.6.6.1
>
prev parent reply other threads:[~2010-05-27 14:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-27 5:40 [Qemu-devel] [PATCH] msix: remove duplicated defines Isaku Yamahata
2010-05-27 14:15 ` Michael S. Tsirkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100527141507.GE8287@redhat.com \
--to=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=yamahata@valinux.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).