From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=35509 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OHhDg-0000yv-2M for qemu-devel@nongnu.org; Thu, 27 May 2010 13:50:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OHhDe-0000jW-Mh for qemu-devel@nongnu.org; Thu, 27 May 2010 13:50:11 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58382) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OHhDe-0000jJ-FF for qemu-devel@nongnu.org; Thu, 27 May 2010 13:50:10 -0400 Date: Thu, 27 May 2010 14:50:02 -0300 From: Luiz Capitulino Message-ID: <20100527145002.20f4d919@redhat.com> In-Reply-To: <1274202469-9332-1-git-send-email-miguel.filho@gmail.com> References: <1274202469-9332-1-git-send-email-miguel.filho@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH v4 0/10] Introduce 'info netdevices' with QMP support List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Miguel Di Ciurcio Filho Cc: qemu-devel@nongnu.org, armbru@redhat.com On Tue, 18 May 2010 14:07:39 -0300 Miguel Di Ciurcio Filho wrote: > The VLANClientState structure has the member info_str, a simple string that > is filled with information about NIC devices and used on monitor calls. > > There is no coherent formatting of this string by all the NIC devices, > making it difficult to parse and represent this information over QMP. > > To make the transition to QMP safe, we leave the current 'info network' command > as is, and introduce a new one: 'info netdevices'. Sorry for the long delay in reviewing this series.. Most important comment is: QMP development process is changing and now it's required that any protocol change updates the qemu-monitor.hx file with QMP info. However, it's not merged yet so you could base your series on top of this series, which is also in my master branch: http://lists.gnu.org/archive/html/qemu-devel/2010-05/msg01605.html Another option is to send the doc patch separately w/o any code and only go back to code when there's consensus wrt new command. Small comments on separate patches follow.