From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=43091 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OI0Ro-0004hR-6Y
	for qemu-devel@nongnu.org; Fri, 28 May 2010 10:22:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <paul@codesourcery.com>) id 1OI0Rn-00084k-3J
	for qemu-devel@nongnu.org; Fri, 28 May 2010 10:22:04 -0400
Received: from mail.codesourcery.com ([38.113.113.100]:47756)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <paul@codesourcery.com>) id 1OI0Rm-00084O-QV
	for qemu-devel@nongnu.org; Fri, 28 May 2010 10:22:03 -0400
From: Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] [PATCH] all vga: refuse hotplugging.
Date: Fri, 28 May 2010 15:21:29 +0100
References: <1274863397-15005-1-git-send-email-kraxel@redhat.com>
In-Reply-To: <1274863397-15005-1-git-send-email-kraxel@redhat.com>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Message-Id: <201005281521.30359.paul@codesourcery.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Gerd Hoffmann <kraxel@redhat.com>

> Try to pci hotplug a vga card, watch qemu die with hw_error().
> This patch fixes it.

I think this is wrong. There's no reason why VGA adapters shouldn't be 
hotplugged.  You should fix the underlying problems that prevent hotplugging 
(or make them fail gracefully).

Paul