From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Cc: Frank Mehnert <Frank.Mehnert@sun.com>
Subject: Re: [Qemu-devel] hw/serial.c: Xmit fifo never used
Date: Fri, 28 May 2010 15:31:26 +0100 [thread overview]
Message-ID: <201005281531.26774.paul@codesourcery.com> (raw)
In-Reply-To: <201005261207.31310.frank.mehnert@sun.com>
> The problem is that this path is never used as tsr_retry is never > 0
> initially. So if qemu_chr_write() fails, we never try again but drop
qemu_chr_write is a blocking interface. It should only fail if an
unrecoverable error occurs. In that case there's noting useful we can do, and
no reason to retry.
Paul
prev parent reply other threads:[~2010-05-28 14:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-26 10:07 [Qemu-devel] hw/serial.c: Xmit fifo never used Frank Mehnert
2010-05-26 10:32 ` [Qemu-devel] " Jan Kiszka
2010-05-26 11:06 ` Frank Mehnert
2010-05-26 11:16 ` Jan Kiszka
2010-05-26 11:42 ` Stefano Stabellini
2010-05-26 20:06 ` Frank Mehnert
2010-05-27 8:21 ` Jan Kiszka
2010-05-28 14:31 ` Paul Brook [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201005281531.26774.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=Frank.Mehnert@sun.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).