From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=42741 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OI0bP-0007Ta-2w
	for qemu-devel@nongnu.org; Fri, 28 May 2010 10:31:59 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <paul@codesourcery.com>) id 1OI0bN-0001JL-Pq
	for qemu-devel@nongnu.org; Fri, 28 May 2010 10:31:58 -0400
Received: from mail.codesourcery.com ([38.113.113.100]:59930)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <paul@codesourcery.com>) id 1OI0bN-0001J0-Hq
	for qemu-devel@nongnu.org; Fri, 28 May 2010 10:31:57 -0400
From: Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] hw/serial.c: Xmit fifo never used
Date: Fri, 28 May 2010 15:31:26 +0100
References: <201005261207.31310.frank.mehnert@sun.com>
In-Reply-To: <201005261207.31310.frank.mehnert@sun.com>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Message-Id: <201005281531.26774.paul@codesourcery.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Frank Mehnert <Frank.Mehnert@sun.com>

> The problem is that this path is never used as tsr_retry is never > 0
> initially. So if qemu_chr_write() fails, we never try again but drop

qemu_chr_write is a blocking interface. It should only fail if an 
unrecoverable error occurs. In that case there's noting useful we can do, and 
no reason to retry.

Paul