From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=57746 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OI1jC-0003PK-Hh
	for qemu-devel@nongnu.org; Fri, 28 May 2010 11:44:10 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <gleb@redhat.com>) id 1OI1jB-0006ev-9b
	for qemu-devel@nongnu.org; Fri, 28 May 2010 11:44:06 -0400
Received: from mx1.redhat.com ([209.132.183.28]:9665)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <gleb@redhat.com>) id 1OI1jB-0006en-3A
	for qemu-devel@nongnu.org; Fri, 28 May 2010 11:44:05 -0400
Date: Fri, 28 May 2010 18:44:02 +0300
From: Gleb Natapov <gleb@redhat.com>
Message-ID: <20100528154402.GB3604@redhat.com>
References: <4BFFE03F.40606@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4BFFE03F.40606@redhat.com>
Subject: [Qemu-devel] Re: [SeaBIOS] SMBIOS strings
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jes Sorensen <Jes.Sorensen@redhat.com>
Cc: seabios@seabios.org, QEMU Developers <qemu-devel@nongnu.org>

On Fri, May 28, 2010 at 05:24:47PM +0200, Jes Sorensen wrote:
> I guess the Socket Designation in particular might have been done for a
> reason?
> 
It was part of commit cf2affa6de. And was a result of moving to
snprintf() instead of direct string manipulation. Before that
string was created like that:
    memcpy((char *)start, "CPU  " "\0" "" "\0" "", 7);
       ((char *)start)[4] = cpu_number + '0';
Which start to produce strange cpu numbers for cpus greater then 9. I
doubt we want to go back to that ;)

--
			Gleb.