From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=45327 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OI5Bm-0001C5-TG
	for qemu-devel@nongnu.org; Fri, 28 May 2010 15:25:53 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <aurelien@aurel32.net>) id 1OI5Bi-0007hQ-Nv
	for qemu-devel@nongnu.org; Fri, 28 May 2010 15:25:47 -0400
Received: from hall.aurel32.net ([88.191.82.174]:56965)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <aurelien@aurel32.net>) id 1OI5Bi-0007hH-Gl
	for qemu-devel@nongnu.org; Fri, 28 May 2010 15:25:46 -0400
Date: Fri, 28 May 2010 21:25:45 +0200
From: Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH] arm: prevent coprocessor IO reset
Message-ID: <20100528192545.GD4621@ohm.aurel32.net>
References: <1273351363-9864-1-git-send-email-lars@segv.dk>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Content-Disposition: inline
In-Reply-To: <1273351363-9864-1-git-send-email-lars@segv.dk>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Lars Munch <lars@segv.dk>
Cc: qemu-devel@nongnu.org

On Sat, May 08, 2010 at 10:42:43PM +0200, Lars Munch wrote:
> This prevent coprocessor IO structure from being reset on cpu reset. This was
> a problem for PXA which uses coprocessor 6 and 14.
> 
> Signed-off-by: Lars Munch <lars@segv.dk>

Thanks, applied.

> ---
>  target-arm/cpu.h |   14 +++++++-------
>  1 files changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/target-arm/cpu.h b/target-arm/cpu.h
> index 1e34541..f3d138d 100644
> --- a/target-arm/cpu.h
> +++ b/target-arm/cpu.h
> @@ -148,13 +148,6 @@ typedef struct CPUARMState {
>          int pending_exception;
>      } v7m;
>  
> -    /* Coprocessor IO used by peripherals */
> -    struct {
> -        ARMReadCPFunc *cp_read;
> -        ARMWriteCPFunc *cp_write;
> -        void *opaque;
> -    } cp[15];
> -
>      /* Thumb-2 EE state.  */
>      uint32_t teecr;
>      uint32_t teehbr;
> @@ -204,6 +197,13 @@ typedef struct CPUARMState {
>      CPU_COMMON
>  
>      /* These fields after the common ones so they are preserved on reset.  */
> +
> +    /* Coprocessor IO used by peripherals */
> +    struct {
> +        ARMReadCPFunc *cp_read;
> +        ARMWriteCPFunc *cp_write;
> +        void *opaque;
> +    } cp[15];
>      void *nvic;
>      struct arm_boot_info *boot_info;
>  } CPUARMState;
> -- 
> 1.7.1
> 
> 
> 
> 

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net