From: Aurelien Jarno <aurelien@aurel32.net>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] musicpal: Drop redundant reset call
Date: Fri, 28 May 2010 21:49:06 +0200 [thread overview]
Message-ID: <20100528194906.GG4621@ohm.aurel32.net> (raw)
In-Reply-To: <4BEBFA26.50300@web.de>
On Thu, May 13, 2010 at 03:09:58PM +0200, Jan Kiszka wrote:
> Reset is now triggered after init, no need for explicit calls anymore.
Thanks, applied.
> Signed-off-by: Jan Kiszka <jan.kiszka@web.de>
> ---
> hw/musicpal.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/hw/musicpal.c b/hw/musicpal.c
> index ebd933e..d44c5a0 100644
> --- a/hw/musicpal.c
> +++ b/hw/musicpal.c
> @@ -1295,8 +1295,6 @@ static int musicpal_gpio_init(SysBusDevice *dev)
> musicpal_gpio_writefn, s);
> sysbus_init_mmio(dev, MP_GPIO_SIZE, iomemtype);
>
> - musicpal_gpio_reset(&dev->qdev);
> -
> qdev_init_gpio_out(&dev->qdev, s->out, ARRAY_SIZE(s->out));
>
> qdev_init_gpio_in(&dev->qdev, musicpal_gpio_pin_event, 32);
> --
> 1.6.0.2
>
--
Aurelien Jarno GPG: 1024D/F1BCDB73
aurelien@aurel32.net http://www.aurel32.net
prev parent reply other threads:[~2010-05-28 19:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-13 13:09 [Qemu-devel] [PATCH] musicpal: Drop redundant reset call Jan Kiszka
2010-05-28 19:49 ` Aurelien Jarno [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100528194906.GG4621@ohm.aurel32.net \
--to=aurelien@aurel32.net \
--cc=jan.kiszka@web.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).