From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=45752 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OI5YK-0003Q5-SV for qemu-devel@nongnu.org; Fri, 28 May 2010 15:49:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OI5YJ-0002Em-Lf for qemu-devel@nongnu.org; Fri, 28 May 2010 15:49:08 -0400 Received: from hall.aurel32.net ([88.191.82.174]:49674) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OI5YJ-0002Ef-HG for qemu-devel@nongnu.org; Fri, 28 May 2010 15:49:07 -0400 Date: Fri, 28 May 2010 21:49:06 +0200 From: Aurelien Jarno Subject: Re: [Qemu-devel] [PATCH] musicpal: Drop redundant reset call Message-ID: <20100528194906.GG4621@ohm.aurel32.net> References: <4BEBFA26.50300@web.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <4BEBFA26.50300@web.de> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: qemu-devel On Thu, May 13, 2010 at 03:09:58PM +0200, Jan Kiszka wrote: > Reset is now triggered after init, no need for explicit calls anymore. Thanks, applied. > Signed-off-by: Jan Kiszka > --- > hw/musicpal.c | 2 -- > 1 files changed, 0 insertions(+), 2 deletions(-) > > diff --git a/hw/musicpal.c b/hw/musicpal.c > index ebd933e..d44c5a0 100644 > --- a/hw/musicpal.c > +++ b/hw/musicpal.c > @@ -1295,8 +1295,6 @@ static int musicpal_gpio_init(SysBusDevice *dev) > musicpal_gpio_writefn, s); > sysbus_init_mmio(dev, MP_GPIO_SIZE, iomemtype); > > - musicpal_gpio_reset(&dev->qdev); > - > qdev_init_gpio_out(&dev->qdev, s->out, ARRAY_SIZE(s->out)); > > qdev_init_gpio_in(&dev->qdev, musicpal_gpio_pin_event, 32); > -- > 1.6.0.2 > -- Aurelien Jarno GPG: 1024D/F1BCDB73 aurelien@aurel32.net http://www.aurel32.net