From: Aurelien Jarno <aurelien@aurel32.net>
To: Dmitry Antipov <antipov@mvista.com>
Cc: qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] MIPS DINSU
Date: Fri, 28 May 2010 22:03:07 +0200 [thread overview]
Message-ID: <20100528200307.GH4621@ohm.aurel32.net> (raw)
In-Reply-To: <4BF13485.8000903@mvista.com>
On Mon, May 17, 2010 at 04:20:21PM +0400, Dmitry Antipov wrote:
> Hello,
>
> shouldn't it be in that way?
>
> Dmitry
>
Good catch, it is correct. Would you mind resending the patch with a
Signed-off-by: line?
> --- qemu-0.12.4/target-mips/translate.c 2010-05-17 16:12:58.048661610 +0400
> +++ qemu-0.12.4/target-mips/translate.c 2010-05-17 16:13:12.281656754 +0400
> @@ -2761,7 +2761,7 @@
> case OPC_DINSU:
> if (lsb > msb)
> goto fail;
> - mask = ((1ULL << (msb - lsb + 1)) - 1) << lsb;
> + mask = ((1ULL << (msb - lsb + 1)) - 1) << (lsb + 32);
> gen_load_gpr(t0, rt);
> tcg_gen_andi_tl(t0, t0, ~mask);
> tcg_gen_shli_tl(t1, t1, lsb + 32);
--
Aurelien Jarno GPG: 1024D/F1BCDB73
aurelien@aurel32.net http://www.aurel32.net
prev parent reply other threads:[~2010-05-28 20:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-17 12:20 [Qemu-devel] [PATCH] MIPS DINSU Dmitry Antipov
2010-05-28 20:03 ` Aurelien Jarno [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100528200307.GH4621@ohm.aurel32.net \
--to=aurelien@aurel32.net \
--cc=antipov@mvista.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).