* [Qemu-devel] [PATCH] MIPS DINSU
@ 2010-05-17 12:20 Dmitry Antipov
2010-05-28 20:03 ` Aurelien Jarno
0 siblings, 1 reply; 2+ messages in thread
From: Dmitry Antipov @ 2010-05-17 12:20 UTC (permalink / raw)
To: qemu-devel
[-- Attachment #1: Type: text/plain, Size: 46 bytes --]
Hello,
shouldn't it be in that way?
Dmitry
[-- Attachment #2: qemu-0.12.4-mips_dinsu.patch --]
[-- Type: text/plain, Size: 478 bytes --]
--- qemu-0.12.4/target-mips/translate.c 2010-05-17 16:12:58.048661610 +0400
+++ qemu-0.12.4/target-mips/translate.c 2010-05-17 16:13:12.281656754 +0400
@@ -2761,7 +2761,7 @@
case OPC_DINSU:
if (lsb > msb)
goto fail;
- mask = ((1ULL << (msb - lsb + 1)) - 1) << lsb;
+ mask = ((1ULL << (msb - lsb + 1)) - 1) << (lsb + 32);
gen_load_gpr(t0, rt);
tcg_gen_andi_tl(t0, t0, ~mask);
tcg_gen_shli_tl(t1, t1, lsb + 32);
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] MIPS DINSU
2010-05-17 12:20 [Qemu-devel] [PATCH] MIPS DINSU Dmitry Antipov
@ 2010-05-28 20:03 ` Aurelien Jarno
0 siblings, 0 replies; 2+ messages in thread
From: Aurelien Jarno @ 2010-05-28 20:03 UTC (permalink / raw)
To: Dmitry Antipov; +Cc: qemu-devel
On Mon, May 17, 2010 at 04:20:21PM +0400, Dmitry Antipov wrote:
> Hello,
>
> shouldn't it be in that way?
>
> Dmitry
>
Good catch, it is correct. Would you mind resending the patch with a
Signed-off-by: line?
> --- qemu-0.12.4/target-mips/translate.c 2010-05-17 16:12:58.048661610 +0400
> +++ qemu-0.12.4/target-mips/translate.c 2010-05-17 16:13:12.281656754 +0400
> @@ -2761,7 +2761,7 @@
> case OPC_DINSU:
> if (lsb > msb)
> goto fail;
> - mask = ((1ULL << (msb - lsb + 1)) - 1) << lsb;
> + mask = ((1ULL << (msb - lsb + 1)) - 1) << (lsb + 32);
> gen_load_gpr(t0, rt);
> tcg_gen_andi_tl(t0, t0, ~mask);
> tcg_gen_shli_tl(t1, t1, lsb + 32);
--
Aurelien Jarno GPG: 1024D/F1BCDB73
aurelien@aurel32.net http://www.aurel32.net
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-05-28 20:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-05-17 12:20 [Qemu-devel] [PATCH] MIPS DINSU Dmitry Antipov
2010-05-28 20:03 ` Aurelien Jarno
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).