From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=59856 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OI5lv-0005wh-9G
	for qemu-devel@nongnu.org; Fri, 28 May 2010 16:03:12 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <aurelien@aurel32.net>) id 1OI5lu-0003t6-3p
	for qemu-devel@nongnu.org; Fri, 28 May 2010 16:03:11 -0400
Received: from hall.aurel32.net ([88.191.82.174]:50747)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <aurelien@aurel32.net>) id 1OI5lt-0003sh-S0
	for qemu-devel@nongnu.org; Fri, 28 May 2010 16:03:10 -0400
Date: Fri, 28 May 2010 22:03:07 +0200
From: Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH] MIPS DINSU
Message-ID: <20100528200307.GH4621@ohm.aurel32.net>
References: <4BF13485.8000903@mvista.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Content-Disposition: inline
In-Reply-To: <4BF13485.8000903@mvista.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Dmitry Antipov <antipov@mvista.com>
Cc: qemu-devel <qemu-devel@nongnu.org>

On Mon, May 17, 2010 at 04:20:21PM +0400, Dmitry Antipov wrote:
> Hello,
> 
> shouldn't it be in that way?
> 
> Dmitry
> 

Good catch, it is correct. Would you mind resending the patch with a
Signed-off-by: line?

> --- qemu-0.12.4/target-mips/translate.c	2010-05-17 16:12:58.048661610 +0400
> +++ qemu-0.12.4/target-mips/translate.c	2010-05-17 16:13:12.281656754 +0400
> @@ -2761,7 +2761,7 @@
>      case OPC_DINSU:
>          if (lsb > msb)
>              goto fail;
> -        mask = ((1ULL << (msb - lsb + 1)) - 1) << lsb;
> +        mask = ((1ULL << (msb - lsb + 1)) - 1) << (lsb + 32);
>          gen_load_gpr(t0, rt);
>          tcg_gen_andi_tl(t0, t0, ~mask);
>          tcg_gen_shli_tl(t1, t1, lsb + 32);


-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net