* [Qemu-devel] [PATCH] sparc64: fix 128-bit atomic load from nucleus context v1
@ 2010-05-28 21:05 Igor V. Kovalenko
2010-05-29 7:42 ` Blue Swirl
0 siblings, 1 reply; 2+ messages in thread
From: Igor V. Kovalenko @ 2010-05-28 21:05 UTC (permalink / raw)
To: qemu-devel
From: Igor V. Kovalenko <igor.v.kovalenko@gmail.com>
- change 128-bit atomic loads to reference nucleus context
v0->v1: dropped disassembler change
Signed-off-by: Igor V. Kovalenko <igor.v.kovalenko@gmail.com>
---
target-sparc/op_helper.c | 10 +++++-----
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/target-sparc/op_helper.c b/target-sparc/op_helper.c
index edeeb44..f468e7b 100644
--- a/target-sparc/op_helper.c
+++ b/target-sparc/op_helper.c
@@ -3060,19 +3060,19 @@ void helper_ldda_asi(target_ulong addr, int asi, int rd)
case 0x2c: // Nucleus quad LDD 128 bit atomic LE
helper_check_align(addr, 0xf);
if (rd == 0) {
- env->gregs[1] = ldq_kernel(addr + 8);
+ env->gregs[1] = ldq_nucleus(addr + 8);
if (asi == 0x2c)
bswap64s(&env->gregs[1]);
} else if (rd < 8) {
- env->gregs[rd] = ldq_kernel(addr);
- env->gregs[rd + 1] = ldq_kernel(addr + 8);
+ env->gregs[rd] = ldq_nucleus(addr);
+ env->gregs[rd + 1] = ldq_nucleus(addr + 8);
if (asi == 0x2c) {
bswap64s(&env->gregs[rd]);
bswap64s(&env->gregs[rd + 1]);
}
} else {
- env->regwptr[rd] = ldq_kernel(addr);
- env->regwptr[rd + 1] = ldq_kernel(addr + 8);
+ env->regwptr[rd] = ldq_nucleus(addr);
+ env->regwptr[rd + 1] = ldq_nucleus(addr + 8);
if (asi == 0x2c) {
bswap64s(&env->regwptr[rd]);
bswap64s(&env->regwptr[rd + 1]);
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Qemu-devel] [PATCH] sparc64: fix 128-bit atomic load from nucleus context v1
2010-05-28 21:05 [Qemu-devel] [PATCH] sparc64: fix 128-bit atomic load from nucleus context v1 Igor V. Kovalenko
@ 2010-05-29 7:42 ` Blue Swirl
0 siblings, 0 replies; 2+ messages in thread
From: Blue Swirl @ 2010-05-29 7:42 UTC (permalink / raw)
To: Igor V. Kovalenko; +Cc: qemu-devel
Thanks, applied.
On Fri, May 28, 2010 at 9:05 PM, Igor V. Kovalenko
<igor.v.kovalenko@gmail.com> wrote:
> From: Igor V. Kovalenko <igor.v.kovalenko@gmail.com>
>
> - change 128-bit atomic loads to reference nucleus context
> v0->v1: dropped disassembler change
> Signed-off-by: Igor V. Kovalenko <igor.v.kovalenko@gmail.com>
> ---
> target-sparc/op_helper.c | 10 +++++-----
> 1 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/target-sparc/op_helper.c b/target-sparc/op_helper.c
> index edeeb44..f468e7b 100644
> --- a/target-sparc/op_helper.c
> +++ b/target-sparc/op_helper.c
> @@ -3060,19 +3060,19 @@ void helper_ldda_asi(target_ulong addr, int asi, int rd)
> case 0x2c: // Nucleus quad LDD 128 bit atomic LE
> helper_check_align(addr, 0xf);
> if (rd == 0) {
> - env->gregs[1] = ldq_kernel(addr + 8);
> + env->gregs[1] = ldq_nucleus(addr + 8);
> if (asi == 0x2c)
> bswap64s(&env->gregs[1]);
> } else if (rd < 8) {
> - env->gregs[rd] = ldq_kernel(addr);
> - env->gregs[rd + 1] = ldq_kernel(addr + 8);
> + env->gregs[rd] = ldq_nucleus(addr);
> + env->gregs[rd + 1] = ldq_nucleus(addr + 8);
> if (asi == 0x2c) {
> bswap64s(&env->gregs[rd]);
> bswap64s(&env->gregs[rd + 1]);
> }
> } else {
> - env->regwptr[rd] = ldq_kernel(addr);
> - env->regwptr[rd + 1] = ldq_kernel(addr + 8);
> + env->regwptr[rd] = ldq_nucleus(addr);
> + env->regwptr[rd + 1] = ldq_nucleus(addr + 8);
> if (asi == 0x2c) {
> bswap64s(&env->regwptr[rd]);
> bswap64s(&env->regwptr[rd + 1]);
>
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-05-29 15:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-05-28 21:05 [Qemu-devel] [PATCH] sparc64: fix 128-bit atomic load from nucleus context v1 Igor V. Kovalenko
2010-05-29 7:42 ` Blue Swirl
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).