qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Cc: Blue Swirl <blauwirbel@gmail.com>, "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] Re: [PATCH, RFC 1/4] pci: add I/O registration functions
Date: Fri, 28 May 2010 22:31:41 +0100	[thread overview]
Message-ID: <201005282231.41907.paul@codesourcery.com> (raw)
In-Reply-To: <AANLkTimntHzT-Y-1TUkRQo5yKjgYKJAJ-DvQLsEO6OQM@mail.gmail.com>

> On Thu, May 27, 2010 at 2:39 PM, Michael S. Tsirkin <mst@redhat.com> wrote:
> > On Sun, May 23, 2010 at 08:34:30PM +0000, Blue Swirl wrote:
> >> Convert also APB to use the registration so that
> >> we can remove mem_base.
> >> 
> >> Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
> >> ---
> >>  hw/apb_pci.c |   23 ++++++++++++++++++++-
> >>  hw/pci.c     |   64
> >> ++++++++++++++++++++++++++++++++++----------------------- hw/pci.h    
> >> |    9 +++++++-
> >>  3 files changed, 68 insertions(+), 28 deletions(-)
> > 
> > Probably should mention pci.c changes in the changelog.
> 
> It's the subject.

IMO the body of the commit message should be self-contained.  Many mail 
clients display the body text separately from the subject - the subject tends 
to be grouped with other metadata like to/from addresses.
This makes reading both as a whole confusing and unintuitive.

You can argue that this is a bug in git (and/or many mail clients). However I 
don't see that changing any time soon, so we should adapt our work process 
appropriately.

Some other version control systems (e.g. CVS and SVN) don't have commit 
summary, so this can seem a strange concept when migrating from those systems.

Paul

      reply	other threads:[~2010-05-28 21:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-23 20:34 [Qemu-devel] [PATCH, RFC 1/4] pci: add I/O registration functions Blue Swirl
2010-05-27 14:39 ` [Qemu-devel] " Michael S. Tsirkin
2010-05-27 19:07   ` Blue Swirl
2010-05-28 21:31     ` Paul Brook [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201005282231.41907.paul@codesourcery.com \
    --to=paul@codesourcery.com \
    --cc=blauwirbel@gmail.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).