From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=37125 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OI7A8-0002eN-9N
	for qemu-devel@nongnu.org; Fri, 28 May 2010 17:32:17 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <paul@codesourcery.com>) id 1OI7A5-0006Zf-EV
	for qemu-devel@nongnu.org; Fri, 28 May 2010 17:32:15 -0400
Received: from mail.codesourcery.com ([38.113.113.100]:50692)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <paul@codesourcery.com>) id 1OI7A5-0006ZS-4B
	for qemu-devel@nongnu.org; Fri, 28 May 2010 17:32:13 -0400
From: Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] Re: [PATCH,
	RFC 1/4] pci: add I/O registration functions
Date: Fri, 28 May 2010 22:31:41 +0100
References: <AANLkTilrnMnH1WAJWr1pJj43KAIMP2sid0ceUUTmEqYJ@mail.gmail.com>
	<20100527143918.GA8314@redhat.com>
	<AANLkTimntHzT-Y-1TUkRQo5yKjgYKJAJ-DvQLsEO6OQM@mail.gmail.com>
In-Reply-To: <AANLkTimntHzT-Y-1TUkRQo5yKjgYKJAJ-DvQLsEO6OQM@mail.gmail.com>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="utf-8"
Content-Transfer-Encoding: 7bit
Message-Id: <201005282231.41907.paul@codesourcery.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Blue Swirl <blauwirbel@gmail.com>, "Michael S. Tsirkin" <mst@redhat.com>

> On Thu, May 27, 2010 at 2:39 PM, Michael S. Tsirkin <mst@redhat.com> wrote:
> > On Sun, May 23, 2010 at 08:34:30PM +0000, Blue Swirl wrote:
> >> Convert also APB to use the registration so that
> >> we can remove mem_base.
> >> 
> >> Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
> >> ---
> >>  hw/apb_pci.c |   23 ++++++++++++++++++++-
> >>  hw/pci.c     |   64
> >> ++++++++++++++++++++++++++++++++++----------------------- hw/pci.h    
> >> |    9 +++++++-
> >>  3 files changed, 68 insertions(+), 28 deletions(-)
> > 
> > Probably should mention pci.c changes in the changelog.
> 
> It's the subject.

IMO the body of the commit message should be self-contained.  Many mail 
clients display the body text separately from the subject - the subject tends 
to be grouped with other metadata like to/from addresses.
This makes reading both as a whole confusing and unintuitive.

You can argue that this is a bug in git (and/or many mail clients). However I 
don't see that changing any time soon, so we should adapt our work process 
appropriately.

Some other version control systems (e.g. CVS and SVN) don't have commit 
summary, so this can seem a strange concept when migrating from those systems.

Paul