From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=57957 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OIOkB-0008UL-WA
	for qemu-devel@nongnu.org; Sat, 29 May 2010 12:21:17 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <kevin@koconnor.net>) id 1OIOh6-0001w9-KW
	for qemu-devel@nongnu.org; Sat, 29 May 2010 12:15:29 -0400
Received: from mail-vw0-f45.google.com ([209.85.212.45]:51356)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <kevin@koconnor.net>) id 1OIOh6-0001vh-I2
	for qemu-devel@nongnu.org; Sat, 29 May 2010 12:15:28 -0400
Received: by vws18 with SMTP id 18so1873426vws.4
	for <qemu-devel@nongnu.org>; Sat, 29 May 2010 09:15:27 -0700 (PDT)
Date: Sat, 29 May 2010 12:15:24 -0400
From: Kevin O'Connor <kevin@koconnor.net>
Message-ID: <20100529161524.GA3485@morn.localdomain>
References: <4BFFE03F.40606@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4BFFE03F.40606@redhat.com>
Subject: [Qemu-devel] Re: [SeaBIOS] SMBIOS strings
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jes Sorensen <Jes.Sorensen@redhat.com>
Cc: seabios@seabios.org, QEMU Developers <qemu-devel@nongnu.org>

On Fri, May 28, 2010 at 05:24:47PM +0200, Jes Sorensen wrote:
> We were looking at the dmidecode output from qemu-kvm pre-seabios and
> current qemu-kvm and noticed some of the strings have changed.
[...]
> I wanted to check with the lists if there are any strong feelings about
> this, and whether some of these changes were made for specific reasons?
> 
> For example:
[...]
> -       Vendor: QEMU
> -       Version: QEMU
> +       Vendor: Bochs
> +       Version: Bochs
[...]
> -       Manufacturer: QEMU
> -       ID: 63 06 00 00 FD FB 8B 07
> +       Manufacturer: Bochs
> +       ID: 23 06 00 00 FD FB 8B 07

I made these changes in SeaBIOS when I was cleaning up the ifdefs in
the code.  Instead of "ifdef QEMU" spread around the code, I
abstracted out the various names into CONFIG_APPNAME.  I defaulted the
names to the Bochs based ones because they were the default in the
original Bochs bios code.  So, the only reason for these string
differences is that the default name hasn't been changed.

> Otherwise, if there are no objections, I'll look at adding some patches
> to make it more backwards compatible.

I wonder if making the default names be "SeaBIOS" based instead of
bochs/qemu based would make sense.  That way there isn't an impulse to
change the settings with every emulator seabios runs on.  (Ideally,
the same binary would be run on multiple emulators to simplify
testing.)

-Kevin