From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=51380 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OImxZ-0005Ec-CA
	for qemu-devel@nongnu.org; Sun, 30 May 2010 14:10:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <mst@redhat.com>) id 1OImxY-0003rj-0Q
	for qemu-devel@nongnu.org; Sun, 30 May 2010 14:10:05 -0400
Received: from mx1.redhat.com ([209.132.183.28]:63250)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <mst@redhat.com>) id 1OImxX-0003re-Nd
	for qemu-devel@nongnu.org; Sun, 30 May 2010 14:10:03 -0400
Date: Sun, 30 May 2010 21:05:45 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [PULL] pci, vhost fixes
Message-ID: <20100530180545.GA30132@redhat.com>
References: <20100530155000.GA30051@redhat.com>
	<AANLkTin--RkgbbJVDOLLn4NC3Xi8MnBq4L38IZiAxEMN@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <AANLkTin--RkgbbJVDOLLn4NC3Xi8MnBq4L38IZiAxEMN@mail.gmail.com>
Content-Transfer-Encoding: quoted-printable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel@nongnu.org

On Sun, May 30, 2010 at 04:56:11PM +0000, Blue Swirl wrote:
> On Sun, May 30, 2010 at 3:50 PM, Michael S. Tsirkin <mst@redhat.com> wr=
ote:
> > The following changes since commit 259d5577ae546de27e25a40710f81aa031=
660de8:
> >
> > =A0lsi: Fix value overflow in request tag processing (2010-05-22 15:3=
2:32 +0200)
> >
> > are available in the git repository at:
> > =A0git://git.kernel.org/pub/scm/linux/kernel/git/mst/qemu.git pci
> >
> > Isaku Yamahata (4):
> > =A0 =A0 =A0pci: clean up of pci_set_default_subsystem_id().
> > =A0 =A0 =A0pci: add const to pci_is_express(), pci_config_size().
> > =A0 =A0 =A0pci.h: remove unused constants.
> > =A0 =A0 =A0msix: remove duplicated defines.
> >
> > Michael S. Tsirkin (1):
> > =A0 =A0 =A0vhost: fix build broken by 0bfcd599e3f5c5679cc7d0165a0a182=
2e2f60de2
>=20
> Nack, see 29f91781bd300b228d9c38b9f6c1e0b6a38f25fb.

Did you follow the discussion about that patch before applying?
29f91781bd300b228d9c38b9f6c1e0b6a38f25fb does not make sense
to me, I think it should be reverted.
we have long long value, let us just print with %ll.
casting to uint64 and printing with PRi64 is silly.


--=20
MST