From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=50945 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OIo1P-0004ym-8f for qemu-devel@nongnu.org; Sun, 30 May 2010 15:18:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OInml-0002Tw-A0 for qemu-devel@nongnu.org; Sun, 30 May 2010 15:03:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:25811) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OInmk-0002TI-Ur for qemu-devel@nongnu.org; Sun, 30 May 2010 15:02:59 -0400 Date: Sun, 30 May 2010 21:58:39 +0300 From: "Michael S. Tsirkin" Subject: Re: [Qemu-devel] [PULL] pci, vhost fixes Message-ID: <20100530185839.GA30336@redhat.com> References: <20100530155000.GA30051@redhat.com> <20100530180545.GA30132@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: qemu-devel@nongnu.org On Sun, May 30, 2010 at 06:19:40PM +0000, Blue Swirl wrote: > On Sun, May 30, 2010 at 6:05 PM, Michael S. Tsirkin wr= ote: > > On Sun, May 30, 2010 at 04:56:11PM +0000, Blue Swirl wrote: > >> On Sun, May 30, 2010 at 3:50 PM, Michael S. Tsirkin = wrote: > >> > The following changes since commit 259d5577ae546de27e25a40710f81aa= 031660de8: > >> > > >> > =A0lsi: Fix value overflow in request tag processing (2010-05-22 1= 5:32:32 +0200) > >> > > >> > are available in the git repository at: > >> > =A0git://git.kernel.org/pub/scm/linux/kernel/git/mst/qemu.git pci > >> > > >> > Isaku Yamahata (4): > >> > =A0 =A0 =A0pci: clean up of pci_set_default_subsystem_id(). > >> > =A0 =A0 =A0pci: add const to pci_is_express(), pci_config_size(). > >> > =A0 =A0 =A0pci.h: remove unused constants. > >> > =A0 =A0 =A0msix: remove duplicated defines. > >> > > >> > Michael S. Tsirkin (1): > >> > =A0 =A0 =A0vhost: fix build broken by 0bfcd599e3f5c5679cc7d0165a0a= 1822e2f60de2 > >> > >> Nack, see 29f91781bd300b228d9c38b9f6c1e0b6a38f25fb. > > > > Did you follow the discussion about that patch before applying? > > 29f91781bd300b228d9c38b9f6c1e0b6a38f25fb does not make sense > > to me, I think it should be reverted. > > we have long long value, let us just print with %ll. > > casting to uint64 and printing with PRi64 is silly. >=20 > We have PRI*64 just for this purpose, so let's use them. The > discussion about that was earlier. Ho hum. As long as enough people got annoyed, there was hope that debian will upodate their mingw port. I guess if everyone works around this in code no one'll bother. Oh well, not important enough to care. --=20 MST