From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=47177 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OJA3b-0003cK-K0
	for qemu-devel@nongnu.org; Mon, 31 May 2010 14:49:53 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <aurelien@aurel32.net>) id 1OJ9zC-0003ZN-7X
	for qemu-devel@nongnu.org; Mon, 31 May 2010 14:45:20 -0400
Received: from hall.aurel32.net ([88.191.82.174]:34686)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <aurelien@aurel32.net>) id 1OJ9zC-0003ZF-1j
	for qemu-devel@nongnu.org; Mon, 31 May 2010 14:45:18 -0400
Date: Mon, 31 May 2010 20:45:16 +0200
From: Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH] target-ppc: remove useless line
Message-ID: <20100531184516.GV4621@ohm.aurel32.net>
References: <1275073245-20352-1-git-send-email-thomas_ml@monjalon.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Content-Disposition: inline
In-Reply-To: <1275073245-20352-1-git-send-email-thomas_ml@monjalon.net>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Thomas Monjalon <thomas_ml@monjalon.net>
Cc: qemu-devel@nongnu.org

On Fri, May 28, 2010 at 09:00:45PM +0200, Thomas Monjalon wrote:
> From: Thomas Monjalon <thomas@monjalon.net>
> 
> This line was a bit clear.
> The next lines set or reset this bit (LE) depending of another bit (ILE).
> So the first line is useless.

Thanks, applied.

> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
>  target-ppc/helper.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/target-ppc/helper.c b/target-ppc/helper.c
> index 3d843b5..dabf1fd 100644
> --- a/target-ppc/helper.c
> +++ b/target-ppc/helper.c
> @@ -2591,7 +2591,6 @@ static inline void powerpc_excp(CPUState *env, int excp_model, int excp)
>  #if 0 /* Fix this: not on all targets */
>      new_msr &= ~((target_ulong)1 << MSR_PMM);
>  #endif
> -    new_msr &= ~((target_ulong)1 << MSR_LE);
>      if (msr_ile)
>          new_msr |= (target_ulong)1 << MSR_LE;
>      else
> -- 
> 1.7.1
> 
> 
> 
> 
> 

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net