From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=46040 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OJSmX-0004E2-Md
	for qemu-devel@nongnu.org; Tue, 01 Jun 2010 10:49:33 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <lcapitulino@redhat.com>) id 1OJSmW-0000y8-NC
	for qemu-devel@nongnu.org; Tue, 01 Jun 2010 10:49:29 -0400
Received: from mx1.redhat.com ([209.132.183.28]:63589)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <lcapitulino@redhat.com>) id 1OJSmW-0000y1-EX
	for qemu-devel@nongnu.org; Tue, 01 Jun 2010 10:49:28 -0400
Date: Tue, 1 Jun 2010 11:49:20 -0300
From: Luiz Capitulino <lcapitulino@redhat.com>
Subject: Re: [Qemu-devel] Re: [PATCH] qdev: Reject duplicate and anti-social
	device IDs
Message-ID: <20100601114920.1afb505a@redhat.com>
In-Reply-To: <m3ljayq0c7.fsf@blackfin.pond.sub.org>
References: <cover.1274612367.git.jan.kiszka@web.de>
	<cover.1274612367.git.jan.kiszka@web.de>
	<3715da16813f7cdcb7ec023167a84a94e8a37089.1274612367.git.jan.kiszka@web.de>
	<m37hmnjfve.fsf@blackfin.pond.sub.org>
	<4C021ED5.1080703@redhat.com>
	<m3r5ks8okg.fsf@blackfin.pond.sub.org>
	<4C038882.3080007@redhat.com>
	<m3d3wcrwg7.fsf_-_@blackfin.pond.sub.org>
	<20100601100434.380c6ab3@redhat.com>
	<m3ljayq0c7.fsf@blackfin.pond.sub.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>, Juan Quintela <quintela@redhat.com>, Jan Kiszka <jan.kiszka@siemens.com>, qemu-devel@nongnu.org, Blue Swirl <blauwirbel@gmail.com>, Jan Kiszka <jan.kiszka@web.de>, Gerd Hoffmann <kraxel@redhat.com>, Avi Kivity <avi@redhat.com>

On Tue, 01 Jun 2010 16:44:24 +0200
Markus Armbruster <armbru@redhat.com> wrote:

> Luiz Capitulino <lcapitulino@redhat.com> writes:
> 
> > On Mon, 31 May 2010 16:13:12 +0200
> > Markus Armbruster <armbru@redhat.com> wrote:
> >
> >> We need Device IDs to be unique and not contain '/' so device tree
> >> nodes can always be unambigously referenced by tree path.
> >> 
> >> We already have some protection against duplicate IDs, but it got
> >> holes:
> >> 
> >> * We don't assign IDs to default devices.
> >> 
> >> * -device and device_add use the ID of a qemu_device_opts.  Which
> >>   rejects duplicate IDs.
> >> 
> >> * pci_add nic -net use either the ID or option "name" of
> >>   qemu_net_opts.  And there's our hole.  Reproducible with "-net user
> >>   -net nic,id=foo -device lsi,id=foo".
> >
> >  Two bugs that might not be related to this thread:
> >
> >   * "id" member is not mandatory for the device_add command:
> >
> >     { "execute": "device_add", "arguments": { "driver": "e1000" } }
> >     {"return": {}}
> 
> Works as designed.

 What about netdev_add?

 { "execute": "netdev_add", "arguments": { "type": "user" } }
 {"error": {"class": "MissingParameter", "desc": "Parameter 'id' is missing", "data": {"name": "id"}}}