From: Luiz Capitulino <lcapitulino@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: jan.kiszka@siemens.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 3/9] QMP: First half of the new argument checking code
Date: Wed, 2 Jun 2010 10:53:19 -0300 [thread overview]
Message-ID: <20100602105319.54b66398@redhat.com> (raw)
In-Reply-To: <m3eigphqdc.fsf@blackfin.pond.sub.org>
On Wed, 02 Jun 2010 08:59:11 +0200
Markus Armbruster <armbru@redhat.com> wrote:
> Luiz Capitulino <lcapitulino@redhat.com> writes:
[...]
> > +
> > + type = qobject_to_qstring(obj);
> > + assert(type != NULL);
> > +
> > + if (qstring_get_str(type)[0] == 'O') {
> > + QemuOptsList *opts_list = qemu_find_opts(cmd_arg_name);
> > + assert(opts_list);
> > + res->result = check_opts(opts_list, res->qdict);
>
> I doubt this is the right place for calling check_opts.
Can you suggest the right place?
next prev parent reply other threads:[~2010-06-02 13:53 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-01 20:41 [Qemu-devel] [PATCH 0/9]: QMP: Replace client argument checker Luiz Capitulino
2010-06-01 20:41 ` [Qemu-devel] [PATCH 1/9] QDict: Introduce qdict_get_try_bool() Luiz Capitulino
2010-06-02 6:35 ` Markus Armbruster
2010-06-02 13:53 ` Luiz Capitulino
2010-06-01 20:41 ` [Qemu-devel] [PATCH 2/9] Monitor: handle optional '-' arg as a bool Luiz Capitulino
2010-06-01 20:41 ` [Qemu-devel] [PATCH 3/9] QMP: First half of the new argument checking code Luiz Capitulino
2010-06-02 6:59 ` Markus Armbruster
2010-06-02 13:53 ` Luiz Capitulino [this message]
2010-06-03 7:35 ` Markus Armbruster
2010-06-02 7:22 ` Markus Armbruster
2010-06-02 13:53 ` Luiz Capitulino
2010-06-02 14:52 ` Markus Armbruster
2010-06-01 20:41 ` [Qemu-devel] [PATCH 4/9] QMP: Second " Luiz Capitulino
2010-06-02 7:31 ` Markus Armbruster
2010-06-02 13:54 ` Luiz Capitulino
2010-06-02 14:41 ` Markus Armbruster
2010-06-18 20:30 ` [Qemu-devel] Handling the O-type Luiz Capitulino
2010-06-21 8:12 ` Markus Armbruster
2010-06-21 15:36 ` Luiz Capitulino
2010-06-21 16:50 ` Markus Armbruster
2010-06-01 20:41 ` [Qemu-devel] [PATCH 5/9] QMP: Drop old client argument checker Luiz Capitulino
2010-06-01 20:41 ` [Qemu-devel] [PATCH 6/9] QMP: check_opts(): Minor cleanup Luiz Capitulino
2010-06-01 20:41 ` [Qemu-devel] [PATCH 7/9] QError: Introduce QERR_QMP_BAD_INPUT_OBJECT_MEMBER Luiz Capitulino
2010-06-02 7:34 ` Markus Armbruster
2010-06-01 20:41 ` [Qemu-devel] [PATCH 8/9] QMP: Introduce qmp_check_input_obj() Luiz Capitulino
2010-06-02 7:39 ` Markus Armbruster
2010-06-02 13:55 ` Luiz Capitulino
2010-06-02 14:42 ` Markus Armbruster
2010-06-01 20:41 ` [Qemu-devel] [PATCH 9/9] QMP: Drop old input object checking code Luiz Capitulino
2010-06-02 7:41 ` [Qemu-devel] [PATCH 0/9]: QMP: Replace client argument checker Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100602105319.54b66398@redhat.com \
--to=lcapitulino@redhat.com \
--cc=armbru@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).