From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=52228 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OJoNr-0003SF-TE
	for qemu-devel@nongnu.org; Wed, 02 Jun 2010 09:53:28 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <lcapitulino@redhat.com>) id 1OJoNq-0006D5-KG
	for qemu-devel@nongnu.org; Wed, 02 Jun 2010 09:53:27 -0400
Received: from mx1.redhat.com ([209.132.183.28]:57809)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <lcapitulino@redhat.com>) id 1OJoNq-0006Cu-AD
	for qemu-devel@nongnu.org; Wed, 02 Jun 2010 09:53:26 -0400
Date: Wed, 2 Jun 2010 10:53:19 -0300
From: Luiz Capitulino <lcapitulino@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 3/9] QMP: First half of the new argument
	checking code
Message-ID: <20100602105319.54b66398@redhat.com>
In-Reply-To: <m3eigphqdc.fsf@blackfin.pond.sub.org>
References: <1275424897-32253-1-git-send-email-lcapitulino@redhat.com>
	<1275424897-32253-4-git-send-email-lcapitulino@redhat.com>
	<m3eigphqdc.fsf@blackfin.pond.sub.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: jan.kiszka@siemens.com, qemu-devel@nongnu.org

On Wed, 02 Jun 2010 08:59:11 +0200
Markus Armbruster <armbru@redhat.com> wrote:

> Luiz Capitulino <lcapitulino@redhat.com> writes:

[...]

> > +
> > +    type = qobject_to_qstring(obj);
> > +    assert(type != NULL);
> > +
> > +    if (qstring_get_str(type)[0] == 'O') {
> > +        QemuOptsList *opts_list = qemu_find_opts(cmd_arg_name);
> > +        assert(opts_list);
> > +        res->result = check_opts(opts_list, res->qdict);
> 
> I doubt this is the right place for calling check_opts.

 Can you suggest the right place?