From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=51505 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OJmLQ-0004rS-AZ
	for qemu-devel@nongnu.org; Wed, 02 Jun 2010 07:42:52 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <ryanh@us.ibm.com>) id 1OJmLM-0003mD-E1
	for qemu-devel@nongnu.org; Wed, 02 Jun 2010 07:42:46 -0400
Received: from e31.co.us.ibm.com ([32.97.110.149]:52784)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <ryanh@us.ibm.com>) id 1OJmLM-0003m2-8u
	for qemu-devel@nongnu.org; Wed, 02 Jun 2010 07:42:44 -0400
Received: from d03relay03.boulder.ibm.com (d03relay03.boulder.ibm.com
	[9.17.195.228])
	by e31.co.us.ibm.com (8.14.4/8.13.1) with ESMTP id o52BWLnf029288
	for <qemu-devel@nongnu.org>; Wed, 2 Jun 2010 05:32:21 -0600
Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168])
	by d03relay03.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	o52BgdPS106038
	for <qemu-devel@nongnu.org>; Wed, 2 Jun 2010 05:42:40 -0600
Received: from d03av02.boulder.ibm.com (loopback [127.0.0.1])
	by d03av02.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP
	id o52Bgd28023354
	for <qemu-devel@nongnu.org>; Wed, 2 Jun 2010 05:42:39 -0600
Date: Wed, 2 Jun 2010 06:42:34 -0500
From: Ryan Harper <ryanh@us.ibm.com>
Subject: Re: [Qemu-devel] [PATCH] virtio-blk: assign a default serial number
	if	none provided
Message-ID: <20100602114234.GA19185@us.ibm.com>
References: <20100602014854.GB16406@us.ibm.com>
	<4C060083.4070200@msgid.tls.msk.ru>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4C060083.4070200@msgid.tls.msk.ru>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Michael Tokarev <mjt@tls.msk.ru>
Cc: john cooper <john.cooper@redhat.com>, Ryan Harper <ryanh@us.ibm.com>, qemu-devel@nongnu.org

* Michael Tokarev <mjt@tls.msk.ru> [2010-06-02 01:57]:
> 02.06.2010 05:48, Ryan Harper wrote:
> []
> >  hw/virtio-blk.c |    3 +++
> >+    if (strlen(s->sn) == 0) {
> 
> Just out of curiocity (not that it is wrong or inefficient):
> why
>   strlen(s->sn)
> and not, say,
>   !s->sn[0]
> ?

Just matching how it's done in hw/ide/core.c:ide_init_drive()


-- 
Ryan Harper
Software Engineer; Linux Technology Center
IBM Corp., Austin, Tx
ryanh@us.ibm.com