Re: [Qemu-devel] [PATCH] give some useful error messages when tap open

[Luiz Capitulino <lcapitulino@redhat.com>]

On Wed, 02 Jun 2010 20:26:58 +0200
Markus Armbruster <armbru@redhat.com> wrote:

> Luiz Capitulino <lcapitulino@redhat.com> writes:
> 
> > From: Michael Tokarev <mjt@tls.msk.ru>
> >
> > In net/tap-linux.c, when manipulation of /dev/net/tun fails, it prints
> > (with fprintf) something like this:
> >
> >   warning: could not open /dev/net/tun: no virtual network emulation
> >
> > this has 2 issues:
> >  1) it is not a warning really, it's a fatal error (kvm exits after
> > that),
> >  2) there's no indication as of what's actually wrong: printing errno there
> >     is helpful.
> >
> > The patch below removes the "warning" prefix, uses %m (since it's linux,
> > %m is available as format modifier), and changes fprintf() to %qemu_error().
> 
> To error_report(), you mean.

 It's the original commit log.. Should this be fixed? If so, Michael,
could you resend?

> 
> > Now it prints something like this instead:
> >
> >  could not configure /dev/net/tun: Device or resource busy
> >
> > (there are 2 messages like that in the same function)
> >
> > This fixes Debian bug #578154, see
> > http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=578154
> >
> > Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
> > Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
> 
> Looks good.
>