From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=49059 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OJsyA-0003JE-Sk
	for qemu-devel@nongnu.org; Wed, 02 Jun 2010 14:47:16 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <lcapitulino@redhat.com>) id 1OJskf-0008KZ-QR
	for qemu-devel@nongnu.org; Wed, 02 Jun 2010 14:33:18 -0400
Received: from mx1.redhat.com ([209.132.183.28]:9397)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <lcapitulino@redhat.com>) id 1OJskf-0008KN-FK
	for qemu-devel@nongnu.org; Wed, 02 Jun 2010 14:33:17 -0400
Date: Wed, 2 Jun 2010 15:33:12 -0300
From: Luiz Capitulino <lcapitulino@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] give some useful error messages when tap open
Message-ID: <20100602153312.5f665cb2@redhat.com>
In-Reply-To: <m3r5kpp9xp.fsf@blackfin.pond.sub.org>
References: <20100602143301.0289520c@redhat.com>
	<m3r5kpp9xp.fsf@blackfin.pond.sub.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: mjt@tls.msk.ru, qemu-devel@nongnu.org

On Wed, 02 Jun 2010 20:26:58 +0200
Markus Armbruster <armbru@redhat.com> wrote:

> Luiz Capitulino <lcapitulino@redhat.com> writes:
> 
> > From: Michael Tokarev <mjt@tls.msk.ru>
> >
> > In net/tap-linux.c, when manipulation of /dev/net/tun fails, it prints
> > (with fprintf) something like this:
> >
> >   warning: could not open /dev/net/tun: no virtual network emulation
> >
> > this has 2 issues:
> >  1) it is not a warning really, it's a fatal error (kvm exits after
> > that),
> >  2) there's no indication as of what's actually wrong: printing errno there
> >     is helpful.
> >
> > The patch below removes the "warning" prefix, uses %m (since it's linux,
> > %m is available as format modifier), and changes fprintf() to %qemu_error().
> 
> To error_report(), you mean.

 It's the original commit log.. Should this be fixed? If so, Michael,
could you resend?

> 
> > Now it prints something like this instead:
> >
> >  could not configure /dev/net/tun: Device or resource busy
> >
> > (there are 2 messages like that in the same function)
> >
> > This fixes Debian bug #578154, see
> > http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=578154
> >
> > Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
> > Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
> 
> Looks good.
>