From: Paul Brook <paul@codesourcery.com>
To: "Daniel P. Berrange" <berrange@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Name the default PCI bus "pci.0" on all architectures
Date: Wed, 2 Jun 2010 16:10:56 +0100 [thread overview]
Message-ID: <201006021610.56493.paul@codesourcery.com> (raw)
In-Reply-To: <20100602141242.GA10992@redhat.com>
> The problem is that the ID names of default devices in machines are ABI
> sensitive. Management apps need to know what the ID of these default
> devices are. The x86 machines have already used 'pci.0' as their name
> in the previous 0.12 release and libvirt is using this naming. We later
> discovered many non-x86 archs have a name of just 'pci'. We need a single
> consistent naming across all arches, hence this patch whcih standardizes
> on 'pci.0'.
I think you'll find x86 qdev conversion is both incomplete and incorrect.
Specifically i440fx_int breaks several abstraction boundaries. I raised this
issue at the time, but was told this was only temporary, and would be fixed.
x86 should be made to match the arches that have been converted properly.
> The '.N' convention is used extensively in QEMU and is more
> futureproof as & when QEMU supports multiple buses, without requiring
> apps to use the more verbose device paths to ensure uniquness.
I disagree. Anything that depends on device creation order is fundamentally
broken. If you want to create globally unique user-friendly tags for devices
or busses then that is a completely different problem, and should be done via
explicit aliases. qemu currently has no concept of a "default bus".
Paul
next prev parent reply other threads:[~2010-06-02 15:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-19 16:42 [Qemu-devel] [PATCH] Name the default PCI bus "pci.0" on all architectures Daniel P. Berrange
2010-05-19 19:19 ` Blue Swirl
2010-05-20 10:00 ` Daniel P. Berrange
2010-05-28 19:39 ` Paul Brook
2010-05-29 5:13 ` Markus Armbruster
2010-06-02 15:13 ` Paul Brook
2010-06-11 13:00 ` Markus Armbruster
2010-06-11 14:28 ` Paul Brook
2010-06-02 14:12 ` Daniel P. Berrange
2010-06-02 15:10 ` Paul Brook [this message]
2010-06-02 21:03 ` Gerd Hoffmann
2010-06-03 5:45 ` Paul Brook
2010-06-03 10:14 ` Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201006021610.56493.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=berrange@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).