From: Paul Brook <paul@codesourcery.com>
To: Richard Henderson <rth@twiddle.net>
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: Unposted reserved_va patch
Date: Thu, 3 Jun 2010 05:54:38 +0100 [thread overview]
Message-ID: <201006030554.38803.paul@codesourcery.com> (raw)
In-Reply-To: <4C0692F2.9060203@twiddle.net>
> Re: 68a1c816868b3e35a1da698af412b29e61b1948a
>
> In general, I like the idea (especially since I've proposed it before. ;-)
>
> However:
>
> + if (have_guest_base) {
> + flags |= MAP_FIXED;
> + }
>
> I think this is broken. If the user specifies -G n -R m they're hoping
> or guessing that the range [n,n+m) is free. What they're not expecting
> is for the qemu application or any of the required shared libraries to
> get forcibly unmapped.
>
> I think instead you should simply adjust the error reporting after the
> mmap attempt without MAP_FIXED.
Hmm, maybe. My reasoning was that this is consistent with the current behavior
of the ELF loader. If you specify -G then the target application will be
splatted at that address, regardless of whether it's already used by the host.
Paul
next prev parent reply other threads:[~2010-06-03 4:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-02 17:20 [Qemu-devel] Unposted reserved_va patch Richard Henderson
2010-06-03 4:54 ` Paul Brook [this message]
2010-06-03 14:05 ` [Qemu-devel] " Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201006030554.38803.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).