From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Cc: Glauber Costa <glommer@redhat.com>,
Jan Kiszka <jan.kiszka@web.de>,
aliguori@us.ibm.com
Subject: Re: [Qemu-devel] Re: [PATCH v2 2/2] basic machine opts framework
Date: Thu, 3 Jun 2010 10:02:34 +0100 [thread overview]
Message-ID: <201006031002.35275.paul@codesourcery.com> (raw)
In-Reply-To: <20100602140608.GP19104@mothafucka.localdomain>
> the "irqchip" option, if you note, is not x86-specific, in any case.
> Any machine has an irqchip. The first idea was to use something like
> "apic=in_kernel|userspace" which would be, that, very x86-centric.
How is this not x86-pc specific? All you're doing is creating two different
machines, one with an APIC and one without. In principle this is no different
to what we have with pc v.s. isapc.
If you want machine properties (to avoid having to enumerate all the available
machine variants) then these properties should be machine specific.
Incidentally, you patch appears to allow creation of a machine with a cpu that
claims to have an APIC, but without an APIC present. Is that intentional?
Paul
next prev parent reply other threads:[~2010-06-03 9:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-01 17:56 [Qemu-devel] [PATCH v2 0/2] basic machine opts framework Glauber Costa
2010-06-01 17:56 ` [Qemu-devel] [PATCH v2 1/2] early set current_machine Glauber Costa
2010-06-01 17:56 ` [Qemu-devel] [PATCH v2 2/2] basic machine opts framework Glauber Costa
2010-06-02 7:15 ` [Qemu-devel] " Jan Kiszka
2010-06-02 14:06 ` Glauber Costa
2010-06-03 6:07 ` Jan Kiszka
2010-06-03 13:11 ` Anthony Liguori
2010-06-03 9:02 ` Paul Brook [this message]
2010-06-03 14:13 ` Anthony Liguori
2010-06-03 13:14 ` [Qemu-devel] Re: [PATCH v2 1/2] early set current_machine Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201006031002.35275.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=aliguori@us.ibm.com \
--cc=glommer@redhat.com \
--cc=jan.kiszka@web.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).