From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=42612 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OK6Kf-0002Xq-FX for qemu-devel@nongnu.org; Thu, 03 Jun 2010 05:03:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OK6Ke-0003KO-93 for qemu-devel@nongnu.org; Thu, 03 Jun 2010 05:03:21 -0400 Received: from mail.codesourcery.com ([38.113.113.100]:51653) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OK6Ke-0003K5-04 for qemu-devel@nongnu.org; Thu, 03 Jun 2010 05:03:20 -0400 From: Paul Brook Subject: Re: [Qemu-devel] Re: [PATCH v2 2/2] basic machine opts framework Date: Thu, 3 Jun 2010 10:02:34 +0100 References: <1275414976-18258-1-git-send-email-glommer@redhat.com> <4C0604FE.8070402@web.de> <20100602140608.GP19104@mothafucka.localdomain> In-Reply-To: <20100602140608.GP19104@mothafucka.localdomain> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201006031002.35275.paul@codesourcery.com> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Glauber Costa , Jan Kiszka , aliguori@us.ibm.com > the "irqchip" option, if you note, is not x86-specific, in any case. > Any machine has an irqchip. The first idea was to use something like > "apic=in_kernel|userspace" which would be, that, very x86-centric. How is this not x86-pc specific? All you're doing is creating two different machines, one with an APIC and one without. In principle this is no different to what we have with pc v.s. isapc. If you want machine properties (to avoid having to enumerate all the available machine variants) then these properties should be machine specific. Incidentally, you patch appears to allow creation of a machine with a cpu that claims to have an APIC, but without an APIC present. Is that intentional? Paul