From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=35992 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OKbJJ-0005zV-Gz for qemu-devel@nongnu.org; Fri, 04 Jun 2010 14:08:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OKbCz-0006ya-D7 for qemu-devel@nongnu.org; Fri, 04 Jun 2010 14:01:30 -0400 Received: from mx1.redhat.com ([209.132.183.28]:2845) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OKbCz-0006yR-5K for qemu-devel@nongnu.org; Fri, 04 Jun 2010 14:01:29 -0400 Received: from int-mx08.intmail.prod.int.phx2.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o54I1RnZ015309 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 4 Jun 2010 14:01:27 -0400 Date: Fri, 4 Jun 2010 15:01:20 -0300 From: Luiz Capitulino Subject: Re: [Qemu-devel] [PATCH] monitor: allow device to be ejected if no disk is inserted Message-ID: <20100604150120.752571e8@redhat.com> In-Reply-To: <20100601221219.GB13961@blackpad.lan.raisama.net> References: <20100601221219.GB13961@blackpad.lan.raisama.net> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: kwolf@redhat.com, qemu-devel@nongnu.org On Tue, 1 Jun 2010 19:12:19 -0300 Eduardo Habkost wrote: > I have no clue why the code had the is_inserted() check, as it doesn't matter > if there is a disk present at the host drive, when the user wants the virtual > device to be disconnected from the host device. Makes sense, although I have no idea if doing a bdrv_close() on a bs which doesn't have an image inserted has any side effect. Basic testing works as expected, though. Anyway, I think this should go through the block queue.