From: Nathan Froyd <froydnj@codesourcery.com>
To: Richard Henderson <rth@redhat.com>
Cc: qemu-devel@nongnu.org, aurelien@aurel32.net
Subject: Re: [Qemu-devel] [PATCH 03/10] target-mips: add enum constants for various invocations of FOP
Date: Fri, 4 Jun 2010 10:50:51 -0700 [thread overview]
Message-ID: <20100604175050.GG19235@codesourcery.com> (raw)
In-Reply-To: <4C093BBC.6060509@redhat.com>
On Fri, Jun 04, 2010 at 10:45:32AM -0700, Richard Henderson wrote:
> On 05/24/2010 09:19 AM, Nathan Froyd wrote:
> > @@ -5937,8 +6031,8 @@ static void gen_farith (DisasContext *ctx, uint32_t op1,
> > enum { BINOP, CMPOP, OTHEROP } optype = OTHEROP;
> > uint32_t func = ctx->opcode & 0x3f;
> >
> > - switch (ctx->opcode & FOP(0x3f, 0x1f)) {
> > - case FOP(0, 16):
> > + switch (opc) {
> > + case OPC_ADD_S:
>
> For instance, "opc" would seem to be a good candidate for a variable
> to be switched to the enumeration type.
>
> ... Except that I can't seem to find the definition of "opc" at this
> point in patch 3? It looks like the argument "op1" should be what's
> used here. Is this a case of patches being split incorrectly?
This is indeed supposed to be op1; the typo gets fixed in patch 6.
What's the benefit from declaring op1 as 'enum fopcode' or similar?
-Nathan
next prev parent reply other threads:[~2010-06-04 17:50 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-24 16:19 [Qemu-devel] [PATCH 00/10] target-mips: add microMIPS ASE support, v2 Nathan Froyd
2010-05-24 16:19 ` [Qemu-devel] [PATCH 01/10] target-mips: break out [ls][wd]c1 and rdhwr insn generation Nathan Froyd
2010-06-04 17:47 ` Richard Henderson
2010-06-08 17:48 ` Aurelien Jarno
2010-05-24 16:19 ` [Qemu-devel] [PATCH 02/10] target-mips: add microMIPS-specific bits to mips-defs.h Nathan Froyd
2010-06-04 17:51 ` Richard Henderson
2010-05-24 16:19 ` [Qemu-devel] [PATCH 03/10] target-mips: add enum constants for various invocations of FOP Nathan Froyd
2010-06-04 17:45 ` Richard Henderson
2010-06-04 17:50 ` Nathan Froyd [this message]
2010-06-04 18:31 ` Richard Henderson
2010-05-24 16:19 ` [Qemu-devel] [PATCH 04/10] target-mips: refactor {c, abs}.cond.fmt insns Nathan Froyd
2010-06-04 18:01 ` Richard Henderson
2010-05-24 16:19 ` [Qemu-devel] [PATCH 05/10] target-mips: small changes to use new FMT_ enums Nathan Froyd
2010-06-04 18:02 ` Richard Henderson
2010-05-24 16:19 ` [Qemu-devel] [PATCH 06/10] target-mips: add microMIPS ASE support Nathan Froyd
2010-06-04 18:30 ` Richard Henderson
2010-06-04 18:48 ` Nathan Froyd
2010-05-24 16:19 ` [Qemu-devel] [PATCH 07/10] target-mips: add microMIPS CPUs Nathan Froyd
2010-06-04 18:35 ` Richard Henderson
2010-06-04 18:50 ` Nathan Froyd
2010-05-24 16:19 ` [Qemu-devel] [PATCH 08/10] target-mips: add microMIPS exception handler support Nathan Froyd
2010-06-04 18:33 ` Richard Henderson
2010-05-24 16:19 ` [Qemu-devel] [PATCH 09/10] linux-user: honor low bit of entry PC for MIPS Nathan Froyd
2010-06-04 18:36 ` Richard Henderson
2010-05-24 16:19 ` [Qemu-devel] [PATCH 10/10] hw: honor low bit in mipssim machine Nathan Froyd
2010-06-04 18:37 ` Richard Henderson
2010-06-04 15:51 ` [Qemu-devel] [PATCH 00/10] target-mips: add microMIPS ASE support, v2 Nathan Froyd
2010-06-04 17:26 ` Aurelien Jarno
2010-06-04 17:50 ` Richard Henderson
-- strict thread matches above, loose matches on Subject: below --
2010-05-20 14:52 [Qemu-devel] [PATCH 00/10] target-mips: add microMIPS ASE support Nathan Froyd
2010-05-20 14:52 ` [Qemu-devel] [PATCH 03/10] target-mips: add enum constants for various invocations of FOP Nathan Froyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100604175050.GG19235@codesourcery.com \
--to=froydnj@codesourcery.com \
--cc=aurelien@aurel32.net \
--cc=qemu-devel@nongnu.org \
--cc=rth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).